Repository navigation
Actuator zone modifications and fixes - #118
Conversation
…better filename formatting
|
I have converted this to a draft because the complex tests won't pass until I fix the complex ANK. Other than that, please take a look and give me feedback on the changes, so we can merge this after the complex solvers are fixed. |
|
I just remembered that I also need to add the files required for the tests to the inputfiles tarball. Can you help me with that step @nwu63 @eirikurj ? |
…d the new input files to mfile
|
A reminder for @anilyil to bump the minor version here and make a release after this is merged. |
| # also add flowpower as an AZ function | ||
| CFDSolver.addFunction("flowpower", "actuator_region", name="flowpower_az") | ||
|
|
||
| def test_actuator_momentum_flux(self): |
There was a problem hiding this comment.
If it tests both momentum and power we should change the test name
There was a problem hiding this comment.
So I think I meant by test momentum flux, is to test adding thrust terms, and checking if it has the correct effect on both momentum and energy fluxes through the boundaries (you can add thrust in the actuator zone and it both adds momentum to the flow, and does work on the flow)
I renamed the tests. Let me know if they are more clear.
|
thanks for the review @joanibal and @sseraj. I think I addressed all of your comments except Josh's comment at: #118 (comment) Once we figure out that test, this is good to go for me. |
|
I think the only other thing is to bump the minor version |
|
I will make the new release after this is merged right? |
Yes, that would be great. |
Purpose
This PR adds the heat addition feature in the actuator region. Just like adding thrust equally among the actuator zone, we can now also specify an amount of heat power to be added to the flow. This BC variable is differentiated. There is an accompanying PR in baseclasses for the definition of the BC variable. See: mdolab/baseclasses#44
This also fixes a few more things:
I have also created several tests for the actuator zone. These are based on the initial efforts of @joanibal, so thank you Josh!
The tests include analysis, adjoint, and partial checks. I also added complex tests, and verified the adjoint sensitivities with the complex step. The complex tests will not run right now because they need fixes for the ANK solver. I am creating this PR right now so people can review the changes, and once the complex ANK is also fixed (will do it soon), then we can merge this PR.
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
I added new real and complex tests. All tests pass for me locally.
Checklist
flake8andblackto make sure the code adheres to PEP-8 and is consistently formatted