Skip to content

Az mod - #44

Merged
ewu63 merged 4 commits into
mdolab:masterfrom
anilyil:az_mod
Feb 9, 2021
Merged

ewu63 merged 4 commits into
mdolab:masterfrom
anilyil:az_mod

Conversation

@anilyil

@anilyil anilyil commented Feb 7, 2021

Copy link
Copy Markdown
Contributor

Purpose

This PR adds the BC variable Heat that is added as an actuator zone modification in ADflow. I also added a few entries to the gitignore.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

See the link to the ADflow PR below for tests.

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@anilyil
anilyil requested a review from a team as a code owner February 7, 2021 19:43
@anilyil
anilyil requested review from Xiaosong2105 and ewu63 February 7, 2021 19:43
@anilyil
anilyil requested review from joanibal and sseraj February 7, 2021 19:44
@anilyil

anilyil commented Feb 8, 2021

Copy link
Copy Markdown
Contributor Author

The relevant PR to ADflow: mdolab/adflow#118

@ewu63
ewu63 merged commit 4584c9b into mdolab:master Feb 9, 2021
@anilyil
anilyil deleted the az_mod branch February 9, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants