Skip to content

Format the code #98

Closed
Closed

Description

@ewu63

Description

Once @marcomangano finishes the PR on rotating frames, the python code needs to be formatted and all linting errors fixed.

Activity

  1. anilyil commented on Mar 24, 2021

    @anilyil
    Contributor

    When formatting, we should also pay attention to the doscstring formatting. See: #118 (comment) Apparently we will need to remove the space before the colon in the parameter descriptions.

  2. self-assigned this
    on Mar 24, 2021
  3. ewu63 commented on Mar 26, 2021

    @ewu63
    CollaboratorAuthor

    Now that #118 is merged I think we can go ahead with the formatting right @sseraj?

  4. sseraj commented on Mar 26, 2021

    @sseraj
    Collaborator

    Yes, I will do that ASAP

  5. anilyil commented on Mar 26, 2021

    @anilyil
    Contributor

    I will make a release before we merge that PR with the complex solver + actuator region stuff. I think formatting fixes can be a patch?

  6. sseraj commented on Mar 26, 2021

    @sseraj
    Collaborator

    I will make a release before we merge that PR with the complex solver + actuator region stuff. I think formatting fixes can be a patch?

    That would be great. No need to wait for the formatting I think. We can make a patch release if we want afterwards like you said.

  7. anilyil commented on Mar 26, 2021

    @anilyil
    Contributor

    Okay, v2.5.0 is up. Feel free to go ahead with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions