Eng 2185 finalization and email for consent tasks by JadeCara · Pull Request #7102 · ethyca/fides

JadeCara · 2025-12-10T18:50:39Z

Description Of Changes

🎯 Add email for consent task completion.

In this PR added a consent finalization email template which is not enabled by default and must be turned on by the user.

Code Changes

ts files:
- clients/admin-ui/src/features/messaging-templates/CustomizableMessagingTemplatesEnum.ts
- clients/admin-ui/src/features/messaging-templates/CustomizableMessagingTemplatesLabelEnum.ts
- clients/admin-ui/src/features/messaging-templates/CustomizableMessagingTemplatesLabelEnum.ts
- clients/admin-ui/src/types/api/models/MessagingActionType.ts
- clients/privacy-center/types/api/models/MessagingActionType.ts
Added new template to src/fides/api/models/messaging_template.py
Added new message to src/fides/api/schemas/messaging/messaging.py
Updated src/fides/api/service/privacy_request/request_runner_service.py with new messaging call
Updated all associated tests

Steps to Confirm

Run with fidesplus pointed at this back end.
From the Privacy Center we need to do a consent request. (http://localhost:3001/ if running locally). We want it to create a DSR which means it must be configured for your area.

If you are not in the US you can add a new privacy center to http://localhost:3000/consent/privacy-experience with a privacy center component or update the US Privacy Center with wherever you are. Either way it must be enabled on the experience page.
The notices on the privacy center must be enabled and have system wide enforcement. You can set this by going to http://localhost:3000/consent/privacy-notices enabling the notices and then clicking in to them to set the enforcment to system wide.

Lets turn on the consent email notification as well. (http://localhost:3000/notifications/templates) enable the one at the end (Consent request completed) - you may need to set a property for it, the default is fine.

Now you can make that consent request. It will take a second because it also uses celery workers but it should come through in the Request Manager (http://localhost:3000/new-privacy-requests)
Then check your emails - you can also test that updating the template works here too.

I edited the text on this one :) )

Pre-Merge Checklist

vercel · 2025-12-10T18:50:44Z

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Review	Updated (UTC)
fides-plus-nightly	Ignored	Preview	Jan 13, 2026 11:02pm
fides-privacy-center	Ignored		Jan 13, 2026 11:02pm

codecov · 2025-12-10T19:52:57Z

Codecov Report

❌ Patch coverage is 78.26087% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.29%. Comparing base (7108d26) to head (efbaa45).

Files with missing lines	Patch %	Lines
.../service/privacy_request/request_runner_service.py	77.77%	6 Missing and 2 partials ⚠️
.../api/service/messaging/message_dispatch_service.py	50.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7102      +/-   ##
==========================================
- Coverage   87.30%   87.29%   -0.02%     
==========================================
  Files         533      533              
  Lines       35090    35121      +31     
  Branches     4067     4073       +6     
==========================================
+ Hits        30635    30658      +23     
- Misses       3570     3576       +6     
- Partials      885      887       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…tasks

greptile-apps · 2025-12-11T19:01:07Z

Greptile Overview

Greptile Summary

This PR adds consent request completion email functionality, mirroring the existing access/erasure completion email workflow. The implementation correctly prioritizes access/erasure emails over consent emails when a privacy request contains multiple action types.

Key Changes

Added PRIVACY_REQUEST_COMPLETE_CONSENT messaging template with default subject "Your consent preferences have been saved" and body "Your consent request has been completed"
Implemented initiate_consent_request_completion_email function in request runner service
Updated finalization checkpoint logic to send consent emails only for consent-only requests (lines 856-893 in request_runner_service.py)
Added new messaging action type across all TypeScript client enums (admin-ui and privacy-center)
Added template to customizable messaging templates, enabling property-specific configuration
Comprehensive test coverage for both DSR 2.0 and DSR 3.0

Implementation Details

The email sending logic follows this priority:

If request has access OR erasure actions → send access/erasure completion email
If request has ONLY consent actions → send consent completion email
Email is disabled by default and must be enabled by users in the notifications templates UI

The implementation is consistent with existing patterns for erasure completion emails (no body params required, simple template rendering).

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The implementation follows established patterns, has comprehensive test coverage for both DSR 2.0 and 3.0, correctly handles email prioritization, and properly integrates with the existing messaging infrastructure. The changes are well-scoped and do not introduce breaking changes.
No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
src/fides/api/service/privacy_request/request_runner_service.py	4/5	Added `initiate_consent_request_completion_email` function and integrated consent email logic into finalization checkpoint. Logic correctly sends consent completion emails only for consent-only requests (access/erasure take priority).
src/fides/api/service/messaging/message_dispatch_service.py	5/5	Added consent completion email template handling in `_build_email` and `_build_sms` functions. Implementation correctly renders templates without body params, consistent with erasure completion emails.
src/fides/api/models/messaging_template.py	5/5	Added `PRIVACY_REQUEST_COMPLETE_CONSENT` template to `DEFAULT_MESSAGING_TEMPLATES` with appropriate default subject and body content.
src/fides/api/schemas/messaging/messaging.py	5/5	Added `PRIVACY_REQUEST_COMPLETE_CONSENT` enum value and included it in `CONFIGURABLE_MESSAGING_ACTION_TYPES` tuple to enable property-specific messaging configuration.
tests/ops/service/privacy_request/test_request_runner_service.py	5/5	Added comprehensive test coverage for consent completion emails including parametrized tests for both DSR 2.0 and 3.0, covering consent-only requests sending the correct email action type.
clients/admin-ui/cypress/e2e/messaging.cy.ts	5/5	Cypress tests validate that 10 messaging templates are displayed (updated count to include the new consent template). Tests cover template toggling, adding, and configuration flows.

greptile-apps

_{18 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

src/fides/api/service/privacy_request/request_runner_service.py

gilluminate

LGTM

…tasks

JadeCara · 2025-12-11T19:39:25Z

@greptile please review

greptile-apps

_{18 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

…tasks

galvana

I called out one issue but we should also check with @mfbrown to make sure we're not pausing system-generated consent requests.

galvana · 2025-12-15T17:51:49Z

src/fides/api/service/privacy_request/request_runner_service.py

+                            and config_proxy.execution.consent_request_finalization_required
+                        )
+                    )
+                    if requires_finalization:


There are some cases where we wouldn't want to pause the request for finalization even if the setting is enabled. I know this is at least the case for requests with a source of consent_webhook. These requests are system-generated and should just continue processing. You might want to check with @mfbrown if there are other sources that we want to exclude from this finalization (like Fides.js or Janus SDK).

What would the impact of manualizing those be? I can imagine that if a notice was used on a website it might be too many DSRs to manually approve. But is there a technical reason beyond human workload?

Do we want to maybe add a specific type etc to the env var that way a user would turn on the finalization for the types they wanted explicitly?

If we have to add this, that would be better yeah. My concern being that source should be more expansive than it currently is and I'd like some future wiggle room to define more of them.

I do think we should add a config to specify which sources require finalization. To the consent point, it would add a lot of manual work to a process that that could process many thousands of webhook responses, so I don't think we can put that work suddenly on customers for all requests.

I agree with @tvandort that we should add the ability to define more sources, more easily.

OK - making an update here. I did a little work on this over the last week. I have several PRs lined up to make Consent Manual Tasks a thing. I will update this PR to handle the email updates and remove the other elements.

The PR chain starts here The first couple are marked ready for review :)

…tasks

JadeCara · 2026-01-13T17:58:04Z

This PR now only does the messaging portion - The consent tasks are being handled in other PRs

JadeCara · 2026-01-13T18:01:01Z

@greptile please review

greptile-apps

_{No files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

JadeCara · 2026-01-13T20:18:43Z

TODO: Need to fix the privacy center save button.

this may need to be done in release candidate will test there and fix there or fix in main.

…tasks

Co-authored-by: Jade Wibbels <jade@ethyca.com>

Jade Wibbels added 4 commits December 10, 2025 18:38

add consent requires finalization

f3bfca5

add email template

1be0a86

update fe and tests

efe6a63

linting

0810248

missed one

785d943

vercel bot deployed to Preview – fides-plus-nightly December 10, 2025 19:21 View deployment

JadeCara added 2 commits December 10, 2025 20:38

Merge branch 'main' into ENG-2185-finalization-and-email-for-consent-…

06a1f5d

…tasks

Merge branch 'main' into ENG-2185-finalization-and-email-for-consent-…

11b84a1

…tasks

vercel bot deployed to Preview – fides-plus-nightly December 11, 2025 12:27 View deployment

JadeCara and others added 5 commits December 11, 2025 14:32

Merge branch 'main' into ENG-2185-finalization-and-email-for-consent-…

fb65995

…tasks

config schema

560b608

refactored a couple tests

9c73071

test refactor

5ba55de

Merge branch 'main' into ENG-2185-finalization-and-email-for-consent-…

955fa34

…tasks

JadeCara marked this pull request as ready for review December 11, 2025 18:44

JadeCara requested review from a team as code owners December 11, 2025 18:44

JadeCara requested review from galvana and gilluminate and removed request for a team December 11, 2025 18:44

vercel bot deployed to Preview – fides-plus-nightly December 11, 2025 18:47 View deployment

greptile-apps bot reviewed Dec 11, 2025

View reviewed changes

src/fides/api/service/privacy_request/request_runner_service.py Outdated Show resolved Hide resolved

gilluminate approved these changes Dec 11, 2025

View reviewed changes

Jade Wibbels and others added 2 commits December 11, 2025 19:38

address logic change in request runner

3f99cf8

Merge branch 'main' into ENG-2185-finalization-and-email-for-consent-…

0602931

…tasks

greptile-apps bot reviewed Dec 11, 2025

View reviewed changes

vercel bot deployed to Preview – fides-plus-nightly December 11, 2025 19:43 View deployment

This was referenced Dec 12, 2025

[ENG-2185] #7117

Closed

ENG-2185 #7124

Merged

Merge branch 'main' into ENG-2185-finalization-and-email-for-consent-…

efbaa45

…tasks

vercel bot deployed to Preview – fides-plus-nightly December 15, 2025 15:08 View deployment

galvana requested changes Dec 15, 2025

View reviewed changes

JadeCara mentioned this pull request Dec 16, 2025

[ENG-2185] #7133

Merged

18 tasks

JadeCara mentioned this pull request Dec 30, 2025

Eng 2185 remove unused cols #7172

Merged

18 tasks

JadeCara mentioned this pull request Jan 12, 2026

[ENG-2185] Update consent graph with manual tasks #7175

Merged

18 tasks

Jade Wibbels and others added 2 commits January 13, 2026 10:52

removed consent finalization kept all messaging

a2434d0

Merge branch 'main' into ENG-2185-finalization-and-email-for-consent-…

5a6f9b5

…tasks

vercel bot deployed to Preview – fides-plus-nightly January 13, 2026 18:02 View deployment

greptile-apps bot reviewed Jan 13, 2026

View reviewed changes

JadeCara mentioned this pull request Jan 13, 2026

[ENG-2185] Adding Consent #7174

Merged

18 tasks

galvana approved these changes Jan 13, 2026

View reviewed changes

Merge branch 'main' into ENG-2185-finalization-and-email-for-consent-…

8106ab6

…tasks

vercel bot deployed to Preview – fides-plus-nightly January 13, 2026 22:50 View deployment

changelog

d4031ca

JadeCara added this pull request to the merge queue Jan 13, 2026

Merged via the queue into main with commit faec957 Jan 14, 2026
60 checks passed

JadeCara deleted the ENG-2185-finalization-and-email-for-consent-tasks branch January 14, 2026 00:18

JadeCara added a commit that referenced this pull request Jan 14, 2026

Eng 2185 finalization and email for consent tasks (#7102)

d9eb40d

Co-authored-by: Jade Wibbels <jade@ethyca.com>

mfbrown pushed a commit that referenced this pull request Jan 27, 2026

Eng 2185 finalization and email for consent tasks (#7102)

6209a36

Co-authored-by: Jade Wibbels <jade@ethyca.com>

Conversation

JadeCara commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description Of Changes

Code Changes

Steps to Confirm

Pre-Merge Checklist

Uh oh!

vercel bot commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

greptile-apps bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Overview

Greptile Summary

Key Changes

Implementation Details

Confidence Score: 5/5

Important Files Changed

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gilluminate left a comment

Choose a reason for hiding this comment

Uh oh!

JadeCara commented Dec 11, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

galvana left a comment

Choose a reason for hiding this comment

Uh oh!

galvana Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

tvandort Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

JadeCara Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

tvandort Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

mfbrown Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

JadeCara Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

JadeCara commented Jan 13, 2026

Uh oh!

JadeCara commented Jan 13, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

JadeCara commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JadeCara commented Dec 10, 2025 •

edited

Loading

vercel bot commented Dec 10, 2025 •

edited

Loading

codecov bot commented Dec 10, 2025 •

edited

Loading

greptile-apps bot commented Dec 11, 2025 •

edited

Loading

JadeCara commented Jan 13, 2026 •

edited

Loading