[ENG-2185] Update consent graph with manual tasks#7175
Conversation
…des into ENG-2185-add-new-jsob-tree-col
Greptile OverviewGreptile SummaryThis PR successfully adds consent support to manual tasks, enabling manual task execution within consent workflows. Key ChangesFrontend (Admin UI):
Backend (Python):
Tests:
ArchitectureThe implementation correctly handles the fact that consent requests don't have data flow through datasets, so:
The changes maintain backward compatibility - existing calls to Confidence Score: 5/5
Important Files ChangedFile Analysis
|
src/fides/api/task/manual/manual_task_conditional_evaluation.py
Outdated
Show resolved
Hide resolved
Additional Comments (1)
The Impact: Users cannot configure consent manual tasks through the UI, even though the backend fully supports them. This is a critical omission for the feature this PR is supposed to add. Fix: |
|
@greptile please review |
| # Filter field-level dependencies by config type | ||
| if dependency.config_field_key is not None and config_types is not None: | ||
| # Get the config type for this field's config | ||
| config_field = dependency.config_field |
There was a problem hiding this comment.
Should this be config_field_key instead?
| config_field = dependency.config_field | |
| config_field = dependency.config_field_key |
There was a problem hiding this comment.
So - originally i had it creating a relationship to the config associated with the key. This is actually not even useful since below we are filtering on consent type anyways. So I am going to remove this if statement.
…ate-consent-graph-with-manual-tasks
Co-authored-by: Jade Wibbels <jade@ethyca.com>
Co-authored-by: Jade Wibbels <jade@ethyca.com>
Ticket ENG-2185
Description Of Changes
🎯 Add Manual Tasks for Consent
This PR updates the Consent Task Graph with Manual Tasks.
Past PRs:
This PR:
Future PRs:
Code Changes
clients/admin-ui/src/- added consent to all the places we see manual task tagssrc/fides/api/service/privacy_request/request_runner_service.pyRequest runner service will now run consent taskssrc/fides/api/task/conditional_dependencies/privacy_request/schemas.py- Updated for consent specific dependency values.src/fides/api/task/manual/manual_task_conditional_evaluation.pyUpdated to evaluate for consent specific dependency valuessrc/fides/api/task/manual/manual_task_utils.pyUpdated with consent task implementations and to use Action type.src/fides/api/task/graph_task.pyupdated consent graph with manual tasksSteps to Confirm
From the Privacy Center we need to do a consent request. (http://localhost:3001/ if running locally). We want it to create a DSR which means it must be configured for your area.
Note: if it shows completed you might need to restart your worker (especially if it was running before you pulled this in for testing.
Verify the consent task appears correctly.
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works