Merged
Conversation
…des into ENG-2185-add-new-jsob-tree-col
Contributor
Author
|
@greptile please review |
added 2 commits
January 12, 2026 16:20
…yca/fides into ENG-2185-add-consent-to-manual-tasks
Contributor
Author
|
@greptile please review |
Contributor
Author
|
@greptile please review |
...igrations/versions/xx_2025_12_31_1320_627c230d9917_add_config_to_manual_task_dependencies.py
Show resolved
Hide resolved
Contributor
Author
|
@greptile please review |
...igrations/versions/xx_2025_12_31_1320_627c230d9917_add_config_to_manual_task_dependencies.py
Show resolved
Hide resolved
Contributor
Author
|
@greptile please review |
galvana
approved these changes
Jan 13, 2026
| ) | ||
| for action_type, has_rules in policy_rules.items() | ||
| if has_rules | ||
| action_type for action_type, has_rules in policy_rules.items() if has_rules |
JadeCara
added a commit
that referenced
this pull request
Jan 13, 2026
Co-authored-by: Jade Wibbels <jade@ethyca.com>
mfbrown
pushed a commit
that referenced
this pull request
Jan 27, 2026
Co-authored-by: Jade Wibbels <jade@ethyca.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2185
Description Of Changes
🎯 Add Manual Tasks for Consent
This PR updates the Manual Tasks to use the Action Type of the associated Policy thus adding consent. It also allows conditions and users to be assigned to a full task (all things) or a specific field (text, attachment or checkbox). It is a clean up based on the first few rounds of customer use and learning actual usage patterns.
Note the consent task is being added here, but is tricky to test before it is added to the consent graph which happens in #7175 the lines that are not tested here are tested in that PR.
Past PRs:
This PR:
Future PRs:
Code Changes
.fides/db_dataset.yml- added new cols for tracking specific configs for conditions/userssrc/fides/api/alembic/migrations/versions/added new cols for tracking specific configs for conditions/userssrc/fides/api/models/manual_task/conditional_dependency.py- added logic for assigning conditions to specific manual task configurations.src/fides/api/models/manual_task/manual_task.py- Updated to use policy action types, added logic for conditional dependencies on specific configssrc/fides/api/models/privacy_request/privacy_request.pyupdated to use action typessrc/fides/api/task/manual/manual_task_conditional_evaluation.pyAdded filtering functionality which will allow us to handle consent tasks with conditions.src/fides/api/task/manual/manual_task_graph_task.py- Updated to use action types, added consent function call.src/fides/api/task/manual/manual_task_utils.py- Updated to use action typesSteps to Confirm
For Manual Task flow:
For new features not yet in the UI - all tests should pass.
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works