-
Notifications
You must be signed in to change notification settings - Fork 612
add flag to explicitly use Browserbase as cloud provider #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kylejeong2
wants to merge
1
commit into
vercel-labs:main
Choose a base branch
from
browserbase:add-timeout-and-flag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−8
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -722,7 +722,7 @@ export class BrowserManager { | |||||||||||||||||||||||||||||||||||||||||||||||||
| this.browserbaseSessionId = session.id; | ||||||||||||||||||||||||||||||||||||||||||||||||||
| this.browserbaseApiKey = browserbaseApiKey; | ||||||||||||||||||||||||||||||||||||||||||||||||||
| this.browser = browser; | ||||||||||||||||||||||||||||||||||||||||||||||||||
| context.setDefaultTimeout(10000); | ||||||||||||||||||||||||||||||||||||||||||||||||||
| context.setDefaultTimeout(60000); | ||||||||||||||||||||||||||||||||||||||||||||||||||
| this.contexts.push(context); | ||||||||||||||||||||||||||||||||||||||||||||||||||
| this.pages.push(page); | ||||||||||||||||||||||||||||||||||||||||||||||||||
| this.activePageIndex = 0; | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
@@ -844,14 +844,26 @@ export class BrowserManager { | |||||||||||||||||||||||||||||||||||||||||||||||||
| return; | ||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||
| // Try connecting to cloud browser providers if configured | ||||||||||||||||||||||||||||||||||||||||||||||||||
| // Browserbase: auto-connects when BROWSERBASE_API_KEY and BROWSERBASE_PROJECT_ID are set | ||||||||||||||||||||||||||||||||||||||||||||||||||
| if (await this.connectToBrowserbase()) { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| // Check for explicit provider flag | ||||||||||||||||||||||||||||||||||||||||||||||||||
| const provider = options.provider ?? process.env.AGENT_BROWSER_PROVIDER; | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||
| // Browserbase: explicit opt-in via -p browserbase or auto-connect when env vars are set | ||||||||||||||||||||||||||||||||||||||||||||||||||
| if (provider === 'browserbase') { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| const connected = await this.connectToBrowserbase(); | ||||||||||||||||||||||||||||||||||||||||||||||||||
| if (!connected) { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| throw new Error( | ||||||||||||||||||||||||||||||||||||||||||||||||||
| 'BROWSERBASE_API_KEY and BROWSERBASE_PROJECT_ID are required when using browserbase as a provider' | ||||||||||||||||||||||||||||||||||||||||||||||||||
| ); | ||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||
| return; | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+852
to
+858
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
When provider='browserbase' is explicitly set, missing env vars produce one error message while API/network failures produce different raw errors, causing inconsistent error handling |
||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||
| // Try auto-connecting to Browserbase when env vars are set (no explicit provider) | ||||||||||||||||||||||||||||||||||||||||||||||||||
| if (!provider && (await this.connectToBrowserbase())) { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| return; | ||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||
| // Browser Use: requires explicit opt-in via -p browseruse flag or AGENT_BROWSER_PROVIDER=browseruse | ||||||||||||||||||||||||||||||||||||||||||||||||||
| const provider = options.provider ?? process.env.AGENT_BROWSER_PROVIDER; | ||||||||||||||||||||||||||||||||||||||||||||||||||
| // Browser Use: requires explicit opt-in via -p browseruse flag | ||||||||||||||||||||||||||||||||||||||||||||||||||
| if (provider === 'browseruse') { | ||||||||||||||||||||||||||||||||||||||||||||||||||
| await this.connectToBrowserUse(); | ||||||||||||||||||||||||||||||||||||||||||||||||||
| return; | ||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing space after 'Cloud browser provider' in environment variable help text