Skip to content

Conversation

@Kylejeong2
Copy link
Contributor

what

extend load timeout to 60s + adding flag to explicitly use browserbase as cloud browser provider

@vercel
Copy link
Contributor

vercel bot commented Jan 23, 2026

@Kylejeong2 is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@vercel vercel bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestions:

  1. Lines 246 and 256 use hardcoded ANSI color codes instead of color module's error_indicator() function, bypassing NO_COLOR environment variable
  1. Line 357 uses hardcoded ANSI escape codes instead of the color module's error_indicator() function, bypassing NO_COLOR environment variable support
Fix on Vercel

Comment on lines +852 to +858
const connected = await this.connectToBrowserbase();
if (!connected) {
throw new Error(
'BROWSERBASE_API_KEY and BROWSERBASE_PROJECT_ID are required when using browserbase as a provider'
);
}
return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const connected = await this.connectToBrowserbase();
if (!connected) {
throw new Error(
'BROWSERBASE_API_KEY and BROWSERBASE_PROJECT_ID are required when using browserbase as a provider'
);
}
return;
try {
const connected = await this.connectToBrowserbase();
if (!connected) {
throw new Error(
'BROWSERBASE_API_KEY and BROWSERBASE_PROJECT_ID are required when using browserbase as a provider'
);
}
return;
} catch (error) {
// Ensure a descriptive error message is thrown
if (error instanceof Error && error.message.includes('BROWSERBASE_API_KEY and BROWSERBASE_PROJECT_ID are required')) {
throw error;
}
throw new Error(
`Failed to connect to Browserbase: ${error instanceof Error ? error.message : String(error)}`
);
}

When provider='browserbase' is explicitly set, missing env vars produce one error message while API/network failures produce different raw errors, causing inconsistent error handling

Fix on Vercel

Environment:
AGENT_BROWSER_SESSION Session name (default: "default")
AGENT_BROWSER_EXECUTABLE_PATH Custom browser executable path
AGENT_BROWSER_PROVIDER Cloud browser provider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
AGENT_BROWSER_PROVIDER Cloud browser provider
AGENT_BROWSER_PROVIDER Cloud browser provider

Trailing space after 'Cloud browser provider' in environment variable help text

Fix on Vercel

yonatangross added a commit to yonatangross/agent-browser that referenced this pull request Jan 24, 2026
Add missing v0.7.0+ features to skill documentation:
- download command and wait --download flag
- --profile flag for persistent browser profiles
- --args, --user-agent, --proxy-bypass flags
- New environment variables (AGENT_BROWSER_PROFILE, AGENT_BROWSER_ARGS, etc.)

New reference docs:
- persistent-profiles.md: Browser profile persistence patterns
- cloud-providers.md: Browserbase and Browser Use integration

Updated proxy-support.md with CLI flags and stealth configuration.

Closes vercel-labs#210

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
yonatangross added a commit to yonatangross/agent-browser that referenced this pull request Jan 25, 2026
Add missing v0.7.0+ features to skill documentation:
- download command and wait --download flag
- --profile flag for persistent browser profiles
- --args, --user-agent, --proxy-bypass flags
- New environment variables (AGENT_BROWSER_PROFILE, AGENT_BROWSER_ARGS, etc.)

New reference docs:
- persistent-profiles.md: Browser profile persistence patterns
- cloud-providers.md: Browserbase and Browser Use integration

Updated proxy-support.md with CLI flags and stealth configuration.

Closes vercel-labs#210

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
yonatangross added a commit to yonatangross/agent-browser that referenced this pull request Jan 26, 2026
Add missing v0.7.0+ features to skill documentation:
- download command and wait --download flag
- --profile flag for persistent browser profiles
- --args, --user-agent, --proxy-bypass flags
- New environment variables (AGENT_BROWSER_PROFILE, AGENT_BROWSER_ARGS, etc.)

New reference docs:
- persistent-profiles.md: Browser profile persistence patterns
- cloud-providers.md: Browserbase and Browser Use integration

Updated proxy-support.md with CLI flags and stealth configuration.

Closes vercel-labs#210

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant