-
Notifications
You must be signed in to change notification settings - Fork 601
add flag to explicitly use Browserbase as cloud provider #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…e as cloud browser provider
|
@Kylejeong2 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Suggestions:
- Lines 246 and 256 use hardcoded ANSI color codes instead of color module's error_indicator() function, bypassing NO_COLOR environment variable
- Line 357 uses hardcoded ANSI escape codes instead of the color module's error_indicator() function, bypassing NO_COLOR environment variable support
| const connected = await this.connectToBrowserbase(); | ||
| if (!connected) { | ||
| throw new Error( | ||
| 'BROWSERBASE_API_KEY and BROWSERBASE_PROJECT_ID are required when using browserbase as a provider' | ||
| ); | ||
| } | ||
| return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const connected = await this.connectToBrowserbase(); | |
| if (!connected) { | |
| throw new Error( | |
| 'BROWSERBASE_API_KEY and BROWSERBASE_PROJECT_ID are required when using browserbase as a provider' | |
| ); | |
| } | |
| return; | |
| try { | |
| const connected = await this.connectToBrowserbase(); | |
| if (!connected) { | |
| throw new Error( | |
| 'BROWSERBASE_API_KEY and BROWSERBASE_PROJECT_ID are required when using browserbase as a provider' | |
| ); | |
| } | |
| return; | |
| } catch (error) { | |
| // Ensure a descriptive error message is thrown | |
| if (error instanceof Error && error.message.includes('BROWSERBASE_API_KEY and BROWSERBASE_PROJECT_ID are required')) { | |
| throw error; | |
| } | |
| throw new Error( | |
| `Failed to connect to Browserbase: ${error instanceof Error ? error.message : String(error)}` | |
| ); | |
| } |
When provider='browserbase' is explicitly set, missing env vars produce one error message while API/network failures produce different raw errors, causing inconsistent error handling
| Environment: | ||
| AGENT_BROWSER_SESSION Session name (default: "default") | ||
| AGENT_BROWSER_EXECUTABLE_PATH Custom browser executable path | ||
| AGENT_BROWSER_PROVIDER Cloud browser provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add missing v0.7.0+ features to skill documentation: - download command and wait --download flag - --profile flag for persistent browser profiles - --args, --user-agent, --proxy-bypass flags - New environment variables (AGENT_BROWSER_PROFILE, AGENT_BROWSER_ARGS, etc.) New reference docs: - persistent-profiles.md: Browser profile persistence patterns - cloud-providers.md: Browserbase and Browser Use integration Updated proxy-support.md with CLI flags and stealth configuration. Closes vercel-labs#210 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add missing v0.7.0+ features to skill documentation: - download command and wait --download flag - --profile flag for persistent browser profiles - --args, --user-agent, --proxy-bypass flags - New environment variables (AGENT_BROWSER_PROFILE, AGENT_BROWSER_ARGS, etc.) New reference docs: - persistent-profiles.md: Browser profile persistence patterns - cloud-providers.md: Browserbase and Browser Use integration Updated proxy-support.md with CLI flags and stealth configuration. Closes vercel-labs#210 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add missing v0.7.0+ features to skill documentation: - download command and wait --download flag - --profile flag for persistent browser profiles - --args, --user-agent, --proxy-bypass flags - New environment variables (AGENT_BROWSER_PROFILE, AGENT_BROWSER_ARGS, etc.) New reference docs: - persistent-profiles.md: Browser profile persistence patterns - cloud-providers.md: Browserbase and Browser Use integration Updated proxy-support.md with CLI flags and stealth configuration. Closes vercel-labs#210 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
what
extend load timeout to 60s + adding flag to explicitly use browserbase as cloud browser provider