-
Notifications
You must be signed in to change notification settings - Fork 448
Add Get View by ID #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add Get View by ID #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinchris
approved these changes
Dec 3, 2020
Contributor
shinchris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v3.1 is correct! I'll file a doc defect for the rest api documentation
Contributor
Author
|
Awesome, I'll go ahead and merge. #752 covers the doc changes. |
t8y8
approved these changes
Dec 4, 2020
Collaborator
t8y8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
shinchris
pushed a commit
that referenced
this pull request
Feb 17, 2021
[Release] Sync master with v0.15 changes ## 0.15.0 (16 Feb 2021) * Added support for python version 3.9 (#744) * Added support for 'Get View by ID' (#750) * Added docs and test data to MANIFEST.in file (#780) * Added owner_id property to ProjectItem (#784) * Added support for skipping connection check while publishing workbook (#791) * Added support for 'Update Subscription' (#794) * Added support for 'Get Groups for a User' (#799) * Improved debug logging by including put/post request contents (#743) * Improved local and active-directory group creation (#770) * Improved 'Update Group' to match server requests/responses (#772) * Improved SiteItem with new properties and functions (#777) * Improved SubscriptionItem with new properties (#794) * Improved the 'type' property of TaskItem to convert server response to enum (#796) * Improved repository to use Github Actions for running tests/linter (#798) * Fixed data_acceleration field causing error in workbook update payload (#741)
shinchris
pushed a commit
that referenced
this pull request
Feb 17, 2021
[Release] Sync master with v0.15 changes * Added support for python version 3.9 (#744) * Added support for 'Get View by ID' (#750) * Added docs and test data to MANIFEST.in file (#780) * Added owner_id property to ProjectItem (#784) * Added support for skipping connection check while publishing workbook (#791) * Added support for 'Update Subscription' (#794) * Added support for 'Get Groups for a User' (#799) * Improved debug logging by including put/post request contents (#743) * Improved local and active-directory group creation (#770) * Improved 'Update Group' to match server requests/responses (#772) * Improved SiteItem with new properties and functions (#777) * Improved SubscriptionItem with new properties (#794) * Improved the 'type' property of TaskItem to convert server response to enum (#796) * Improved repository to use Github Actions for running tests/linter (#798) * Fixed data_acceleration field causing error in workbook update payload (#741)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implementing @t8y8 #680 from latest development branch and adding a couple of tests.
@shinchris can you confirm the API version this was added because the docs say it was 2.0? Through testing I do believe the server minimum is 3.1, so the REST API docs might be wrong.
I have a separate docs PR ready to go once we confirm.