[wip] get_by_id for view #680
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
shinchris
approved these changes
Aug 31, 2020
Contributor
shinchris
left a comment
There was a problem hiding this comment.
It looks like this PR is including some other unrelated changes.
Also would be nice to have a test 😃
| return all_view_items, pagination_item | ||
|
|
||
| # Get 1 view by ID | ||
| @api(version="2.2") |
Contributor
There was a problem hiding this comment.
Querying view by ID was introduced with v3.1
Collaborator
Author
|
@shinchris Thanks! I think I'll have to remake it from the command line and force-push. The web editor automatically included the extra changes. |
Contributor
|
@t8y8 sounds good, thanks! |
Merged
Contributor
|
Recreated as a new PR #750 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying from the web editor