Skip to content

Fix minor bug in request factory due to bool(time(0,0))==False in Python 3.4 #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shinchris merged 3 commits into from
Dec 30, 2019
Merged

Fix minor bug in request factory due to bool(time(0,0))==False in Python 3.4 #545

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2e76ca
Merge pull request #1 from tableau/development
guodah Dec 18, 2019
74af749
fixing a bug due to bool(time(0,0)) is false
guodah Dec 24, 2019
296cdaf
change the null check for end_time at another place
guodah Dec 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tableauserverclient/server/request_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ def create_req(self, schedule_item):
schedule_element.attrib['frequency'] = interval_item._frequency
frequency_element = ET.SubElement(schedule_element, 'frequencyDetails')
frequency_element.attrib['start'] = str(interval_item.start_time)
if hasattr(interval_item, 'end_time') and interval_item.end_time:
if hasattr(interval_item, 'end_time') and interval_item.end_time is not None:
frequency_element.attrib['end'] = str(interval_item.end_time)
if hasattr(interval_item, 'interval') and interval_item.interval:
intervals_element = ET.SubElement(frequency_element, 'intervals')
Expand All @@ -302,7 +302,7 @@ def update_req(self, schedule_item):
schedule_element.attrib['frequency'] = interval_item._frequency
frequency_element = ET.SubElement(schedule_element, 'frequencyDetails')
frequency_element.attrib['start'] = str(interval_item.start_time)
if hasattr(interval_item, 'end_time') and interval_item.end_time:
if hasattr(interval_item, 'end_time') and interval_item.end_time is not None:
frequency_element.attrib['end'] = str(interval_item.end_time)
intervals_element = ET.SubElement(frequency_element, 'intervals')
if hasattr(interval_item, 'interval'):
Expand Down