Fix minor bug in request factory due to bool(time(0,0))==False in Python 3.4 #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for materializeViews as schedule and task type (tableau#542)
Contributor
|
Could you also add the change to line 305, in the update request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it will fail if someone tries to create a schedule with an end_time being time(0,0) using Python 3.4. Looks there is a bug in Python 3.4 (https://stackoverflow.com/questions/28116931/datetime-time0-0-evaluates-as-false-in-boolean-context) which evaluates bool(time(0,0)) to False.
But https://tableau.github.io/server-client-python/docs/ states it supports Python 3.3 or higher.
The fix is just to explicitly check if end_time is None.