Stop reconnection manager polling when calling disconnect or unsubscribing from all channels/groups #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibing from all channels/groups
7c4f4cc to
5c5f929
Compare
Current coverage is 94.12% (diff: 100%)@@ master #72 diff @@
==========================================
Files 35 35
Lines 1802 1805 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1696 1699 +3
Misses 106 106
Partials 0 0
|
Contributor
|
nice! thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PubNub client can get into a reconnection loop after a disconnect or when unsubscribing from all channels/groups. This PR makes sure to clear the _timeTimer interval in both of these cases.