Skip to content

Fix deprecated this capture warning #26174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pps83 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix deprecated this capture warning #26174

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a3035dc
Fix warning: deprecated `this` capture
pps83 Mar 2, 2026
76359fa
Avoid msvc warning
pps83 Mar 12, 2026
bfe7bb4
Merge branch 'main' into main-this-capture
pps83 Mar 12, 2026
dfcfff6
Merge branch 'main' into main-this-capture
karenwuz Apr 7, 2026
b6ea9f7
Merge branch 'main' into main-this-capture
karenwuz Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/google/protobuf/map.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ UntypedMapBase::TypeInfo UntypedMapBase::GetTypeInfoDynamic(
void UntypedMapBase::InsertOrReplaceNodes(Arena* arena, NodeBase* list,
map_index_t count) {
if (ABSL_PREDICT_FALSE(count == 0)) return;
VisitKeyType([=](auto key_type) {
VisitKeyType([this, arena, list, count](auto key_type) {
using Key = typename decltype(key_type)::type;
static_cast<KeyMapBase<Key>&>(*this).InsertOrReplaceNodes(
arena, static_cast<typename KeyMapBase<Key>::KeyNode*>(list), count);
Expand Down
Loading