Fix deprecated this capture warning#26174
Open
pps83 wants to merge 5 commits intoprotocolbuffers:mainfrom
Open
Fix deprecated this capture warning#26174pps83 wants to merge 5 commits intoprotocolbuffers:mainfrom
this capture warning#26174pps83 wants to merge 5 commits intoprotocolbuffers:mainfrom
Conversation
this capturethis capture warning
Contributor
|
Hi, can you rebase? |
Fixed the following warning: > ..\src\google\protobuf\map.cc(302,36): warning : implicit capture of 'this' with a capture default of '=' is deprecated [-Wdeprecated-this-capture] > ..\src\google\protobuf\map.cc(300,17): note: add an explicit capture of 'this' to capture '*this' by reference
2319f24 to
a3035dc
Compare
Contributor
Author
done. The change is very minimal/trivial, shouldn't have required rebasing imo |
honglooker
previously approved these changes
Mar 10, 2026
Contributor
honglooker
left a comment
There was a problem hiding this comment.
Thanks for the multiple contributions to Protobuf! :)
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
|
Looks like CI is not happy?
|
> D:\a\protobuf\protobuf\src\google\protobuf\map.cc(286): error C3791: 'this' cannot be explicitly captured when the default capture mode is by copy (=)
Contributor
Author
updated |
honglooker
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the following warning: