Skip to content

Fix circle-ci builds #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfeurer merged 2 commits into from
Apr 23, 2018
Merged

Fix circle-ci builds #450

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57350e4
FIX circle ci yaml file (remove requirements.txt)
mfeurer Apr 23, 2018
9cc3a02
circle ci: build docs on all branches
mfeurer Apr 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions circle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,11 @@ dependencies:
- pip install --upgrade pip
- pip install --upgrade numpy
- pip install --upgrade scipy
- pip install git+https://github.com/mfeurer/liac-arff.git
Copy link
Member

@janvanrijn janvanrijn Apr 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add:
pip install liac-arff

I don't see it anywhere in this script

Copy link
Collaborator Author

@mfeurer mfeurer Apr 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python setup.py develop takes care of this. Only numpy and scipy need to be present in order to allow the installation of scikit-learn.

# install documentation building dependencies
- pip install --upgrade matplotlib setuptools nose coverage sphinx pillow sphinx-gallery sphinx_bootstrap_theme cython numpydoc scikit-learn nbformat nbconvert
# Installing required packages for `make -C doc check command` to work.
- sudo -E apt-get -yq update
- sudo -E apt-get -yq --no-install-suggests --no-install-recommends --force-yes install dvipng texlive-latex-base texlive-latex-extra
# finally install the requirements of the package to allow autodoc
- pip install -r requirements.txt
Copy link
Member

@janvanrijn janvanrijn Apr 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you enforce the requirements to be installed?

Copy link
Collaborator Author

@mfeurer mfeurer Apr 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python setup.py develop takes care of this. Only numpy and scipy need to be present in order to allow the installation of scikit-learn.

Copy link
Member

@janvanrijn janvanrijn Apr 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit.


# The --user is needed to let sphinx see the source and the binaries
# The pipefail is requested to propagate exit code
Expand All @@ -58,8 +55,3 @@ general:
artifacts:
- "doc/_build/html"
- "~/log.txt"
# Restric the build to the branch master only
branches:
only:
- master
- develop