Merged
Conversation
janvanrijn
reviewed
Apr 23, 2018
| - pip install --upgrade pip | ||
| - pip install --upgrade numpy | ||
| - pip install --upgrade scipy | ||
| - pip install git+https://github.com/mfeurer/liac-arff.git |
Member
There was a problem hiding this comment.
Why not add:
pip install liac-arff
I don't see it anywhere in this script
Collaborator
Author
There was a problem hiding this comment.
python setup.py develop takes care of this. Only numpy and scipy need to be present in order to allow the installation of scikit-learn.
| - sudo -E apt-get -yq update | ||
| - sudo -E apt-get -yq --no-install-suggests --no-install-recommends --force-yes install dvipng texlive-latex-base texlive-latex-extra | ||
| # finally install the requirements of the package to allow autodoc | ||
| - pip install -r requirements.txt |
Member
There was a problem hiding this comment.
How do you enforce the requirements to be installed?
Collaborator
Author
There was a problem hiding this comment.
python setup.py develop takes care of this. Only numpy and scipy need to be present in order to allow the installation of scikit-learn.
Collaborator
Author
|
@janvanrijn you can actually verify this if you click on Details for ci/circleci in the checks window. |
janvanrijn
approved these changes
Apr 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is the last step prior to our first pypi release. We removed the requirements.txt file in PR #438 and therefore need to update the circle-ci build file. Furthermore, this PR enables building of the docs (not deployment) for all branches pushed to github.