-
-
Notifications
You must be signed in to change notification settings - Fork 246
Fix unit tests #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit tests #448
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| *~ | ||
| doc/generated | ||
| examples/.ipynb_checkpoints | ||
| # Byte-compiled / optimized / DLL files | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| from openml.testing import TestBase | ||
| import openml | ||
|
|
||
|
|
||
| class OpenMLTaskTest(TestBase): | ||
| _multiprocess_can_split_ = True | ||
|
|
||
| def test_list_all(self): | ||
| list_datasets = openml.datasets.functions._list_datasets | ||
| datasets = openml.utils.list_all(list_datasets) | ||
|
|
||
| self.assertGreaterEqual(len(datasets), 100) | ||
| for did in datasets: | ||
| self._check_dataset(datasets[did]) | ||
|
|
||
| # TODO implement these tests | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure you didn't forget these?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @janvanrijn you mean we should not verify the datasets?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I mean there's still a TODO in the PR ;) (line 16)
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah you are right, I did not see what you meant because of the lines selected. The TODO seems already implemented. |
||
| # datasets = openml.utils.list_all(list_datasets, limit=50) | ||
| # self.assertEqual(len(datasets), 50) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can just use assertGreater instead of also making use of assertIsInstance, since if the argument is False it will throw AttributeError: 'NoneType' object has no attribute 'fail'.