Merged
Conversation
janvanrijn
approved these changes
Apr 20, 2018
| for did in datasets: | ||
| self._check_dataset(datasets[did]) | ||
|
|
||
| # TODO implement these tests |
Member
There was a problem hiding this comment.
Sure you didn't forget these?
Member
There was a problem hiding this comment.
@janvanrijn you mean we should not verify the datasets?
Member
There was a problem hiding this comment.
I mean there's still a TODO in the PR ;)
(line 16)
Member
There was a problem hiding this comment.
Ah you are right, I did not see what you meant because of the lines selected. The TODO seems already implemented.
ArlindKadra
approved these changes
Apr 20, 2018
ArlindKadra
reviewed
Apr 20, 2018
| downloaded_flow = openml.flows.get_flow(flow_exists) | ||
| setup_exists = openml.setups.setup_exists(downloaded_flow) | ||
| self.assertIsInstance(setup_exists, int) | ||
| self.assertGreater(setup_exists, 0) |
Member
There was a problem hiding this comment.
Maybe we can just use assertGreater instead of also making use of assertIsInstance, since if the argument is False it will throw AttributeError: 'NoneType' object has no attribute 'fail'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few unit tests and adds one which I forgot to check in quite a while ago. Most importantly, the return values to retrieve all runs for a combination of task/setup is now consistent. Furthermore, I think cleaning the test server from lots of runs was really important.