Skip to content

Polish PR template picker #151415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
João Moreno (joaomoreno) merged 6 commits into from
Jun 10, 2022
Merged

Polish PR template picker #151415

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
22f4fe6
🔨 Set ignoreFocusOut to true on PR template selection
babakks Apr 28, 2022
3207521
🔨 Translate PR template paths to relative in quick pick list
babakks Apr 28, 2022
64e7f3a
💄 Shorten line length
babakks Apr 28, 2022
7059b37
⚗️ Update tests with latest required args
babakks Apr 28, 2022
2dc0d02
⚗️ Update GitHub extension unit tests
babakks May 3, 2022
f920cc3
Merge branch 'main' into polish-pr-template-picker
joaomoreno Jun 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into polish-pr-template-picker
  • Loading branch information
@joaomoreno
joaomoreno authored Jun 10, 2022
commit f920cc3d85a6b7815675dbc3ca3adc48616a5670
2 changes: 1 addition & 1 deletion extensions/github/src/pushErrorHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ async function handlePushError(repository: Repository, remote: Remote, refspec:
const askFork = localize('fork', "You don't have permissions to push to '{0}/{1}' on GitHub. Would you like to create a fork and push to it instead?", owner, repo);

const answer = await window.showInformationMessage(askFork, yes, no);
if (answer === no) {
if (answer !== yes) {
return;
}

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.