Polish PR template picker - #151415
Merged
João Moreno (joaomoreno) merged 6 commits intoJun 10, 2022
Merged
Conversation
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Contributor
Author
|
João Moreno (@joaomoreno) Could you please review this? |
Contributor
That's been fixed: #148326 Thanks for the PR! |
João Moreno (joaomoreno)
previously approved these changes
Jun 10, 2022
Alexandru Dima (alexdima)
previously approved these changes
Jun 10, 2022
João Moreno (joaomoreno)
dismissed stale reviews from Alexandru Dima (alexdima) and themself
via
June 10, 2022 12:44
f920cc3
João Moreno (joaomoreno)
self-requested a review
June 10, 2022 12:44
João Moreno (joaomoreno)
approved these changes
Jun 10, 2022
Alexandru Dima (alexdima)
approved these changes
Jun 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #148323
Fixes include:
ignoreFocusOut: true.João Moreno (@joaomoreno) Regarding things didn't work for Joyce Er (@joyceerhl) more than once, I'm not sure what we can do at the this step (i.e., showing the picker). I think it should be related to the previous step (i.e., handling the fork/push events). What's your take on this?