Repository navigation
Only print modified options when switching ap - #116
Merged
Merged
Conversation
sseraj
previously approved these changes
Feb 5, 2021
anilyil
reviewed
Feb 5, 2021
anilyil
requested changes
Feb 5, 2021
anilyil
left a comment
Contributor
There was a problem hiding this comment.
can you check and make sure the "switching to aero problem" print is not done on all procs. we just want the root doing it.
Collaborator
Author
|
I will fix the |
Collaborator
We can update them when we reformat the python scripts imho |
anilyil
self-requested a review
February 5, 2021 16:20
anilyil
approved these changes
Feb 5, 2021
sseraj
approved these changes
Feb 5, 2021
sseraj
left a comment
Collaborator
There was a problem hiding this comment.
I agree with @marcomangano. I think this is fine as is.
3 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Previously, the modified options were printed on every
__call__, which is excessive. Now, they are printed only when switching aero problems, since it's possible for a solver to use different options based on aero problems.Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
This works locally.
Checklist
Put an
xin the boxes that apply.flake8andblackto make sure the code adheres to PEP-8 and is consistently formatted