Repository navigation
Fixed option printing when using solverOptions - #143
Merged
Merged
Conversation
anilyil
approved these changes
May 7, 2021
ewu63
approved these changes
May 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Since the changes in #116, the modified options are printed immediately after switching to a new AeroProblem. However, these options can change later in
setAeroProblemif you specifysolverOptionsinAeroProblem. I moved the print call to be after the call to_setAeroProblemDataso that the finalized options are printed.I also bumped the patch version because we have a few fixes now since the last release. I will make a new release once this is merged.
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.
Checklist
Put an
xin the boxes that apply.flake8andblackto make sure the code adheres to PEP-8 and is consistently formatted