Skip to content

Fixed option printing when using solverOptions - #143

Merged
ewu63 merged 2 commits into
mdolab:masterfrom
sseraj:ap-print-fix
May 7, 2021
Merged

ewu63 merged 2 commits into
mdolab:masterfrom
sseraj:ap-print-fix

Conversation

@sseraj

@sseraj sseraj commented May 6, 2021

Copy link
Copy Markdown
Collaborator

Purpose

Since the changes in #116, the modified options are printed immediately after switching to a new AeroProblem. However, these options can change later in setAeroProblem if you specify solverOptions in AeroProblem. I moved the print call to be after the call to _setAeroProblemData so that the finalized options are printed.

I also bumped the patch version because we have a few fixes now since the last release. I will make a new release once this is merged.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj
sseraj requested a review from a team as a code owner May 6, 2021 23:18
@sseraj
sseraj requested review from Xiaosong2105 and joanibal May 6, 2021 23:18
@ewu63
ewu63 merged commit 661eef4 into mdolab:master May 7, 2021
@sseraj
sseraj deleted the ap-print-fix branch September 29, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants