Translates a with_scope call for select fields#448
Closed
markwpearce wants to merge 4 commits intolocomotivecms:masterfrom
Closed
Translates a with_scope call for select fields#448markwpearce wants to merge 4 commits intolocomotivecms:masterfrom
markwpearce wants to merge 4 commits intolocomotivecms:masterfrom
Conversation
…l for select fields
…no scope is applied.
|
While this seems to fix the original problem, it broke collections without scope for me. I've submitted a pull request on the pull request here: |
Liquid error: undefined method `each_pair' for nil:NilClass
Contributor
Author
|
I need to add some specs to this pull request too. |
|
This is a needed fix. Can this be merged in? |
Member
|
hi @aaronrenner, sure. I will do it ASAP. |
Contributor
|
Hey @markwpearce - would you consider rebasing your branch so I can use this? And perhaps it'll get merged too! |
Contributor
Author
|
I don't have easy access to the code anymore :) |
Contributor
|
Thanks Mark. Anybody know a workaround for scoping by select fields? If I know the select options ObjectId can I specify it somehow in the liquid tag? |
did
added a commit
that referenced
this pull request
Jul 9, 2013
#448) + the slug of a page can have underscore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It makes it easier to write liquid for using with_scope on select fields - you just use the name of the option instead of needing to know it's id: