Update Bazel rules for Go to v0.24.7 #10240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rifelpet
reviewed
Nov 17, 2020
| ) | ||
|
|
||
| container_pull( | ||
| name = "distroless_base_debug_amd64", |
Member
There was a problem hiding this comment.
where are these debug images used?
Member
Author
There was a problem hiding this comment.
These are not being used, but are there for easier debugging during development.
They were there before, so this is the main reason for keeping them.
rifelpet
reviewed
Nov 18, 2020
Member
|
/lgtm |
Member
|
glad we're able to get over the 0.23 wall :) |
Member
Author
And without some ugly hack... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @justinsb @mikesplain @rifelpet