Skip to content
This repository was archived by the owner on Jan 20, 2022. It is now read-only.

Conversation

@hakman
Copy link
Contributor

@hakman hakman commented Nov 14, 2020

... to match kOps.

@justinsb
Copy link
Contributor

Looks good. Any reason not to update rules-go to a newer version that recognizes the newer go version?

@hakman
Copy link
Contributor Author

hakman commented Nov 14, 2020

Looks good. Any reason not to update rules-go to a newer version that recognizes the newer go version?

I guess not in etcd-manager. In kOps it was a problem with output path changes for binaries for which me and @rifelpet couldn't find a simple solution.

@justinsb
Copy link
Contributor

Ah - that makes sense. Let's stick with what you've got here for now, for consistency then.

/approve
/lgtm

@justinsb
Copy link
Contributor

Fix for the deprecation should be in #362

@justinsb
Copy link
Contributor

I merged #362 - do you want to rebase and then I can cut a release? Or should we leave this one till the next etcd-manager release?

@hakman
Copy link
Contributor Author

hakman commented Nov 17, 2020

Let's leave for next release please. Until then maybe we can do it in a nicer way, similar to kubernetes/kops#10240.

@hakman hakman changed the title Update Go to 1.15.4 Update Go to 1.15.5 Dec 2, 2020
@hakman
Copy link
Contributor Author

hakman commented Dec 2, 2020

@justinsb this should make things identical to kOps now.

@hakman hakman changed the title Update Go to 1.15.5 Update Go to 1.15.6 Jan 17, 2021
@hakman
Copy link
Contributor Author

hakman commented Jan 17, 2021

@justinsb I think tis is now ready to go.

@justinsb
Copy link
Contributor

@hakman do you think we should try to do this before kops 1.19.0?

@hakman
Copy link
Contributor Author

hakman commented Jan 18, 2021

@justinsb I think it may be safer to merge this after the new release for 1.19 and create a new release that we will use only on master for now. We will include it later in 1.19.1 if no issues are discovered.

@rifelpet
Copy link
Contributor

Kops 1.19 is built with 1.15.4 for reference

@hakman
Copy link
Contributor Author

hakman commented Jan 19, 2021

Addressing that with kubernetes/kops#10603.

@justinsb
Copy link
Contributor

We discussed in "bonus" office hours that because we consider #391 to be important, we're going to merge this (with 1.15.7 IIRC) and test with #391, and so this will now make 1.19.0 :-)

@hakman hakman changed the title Update Go to 1.15.6 Update Go to 1.15.7 Jan 21, 2021
@hakman
Copy link
Contributor Author

hakman commented Jan 21, 2021

And... success. Looks like both PRs passed the tests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants