Add compileable task evaluation and auto-verification support#2150
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Enjoy a better diff viewing experience by clicking one of these URLs: |
There was a problem hiding this comment.
I wish we can discuss in person before merging. But I'll just keep some notes for later reference. List keeps updating as I review more deeply.
- add
harbor compilethat only does the first half ofharbor execwhich only do task compilation NOT job related stuff like-a, -m, -e, -k, -n, --ak, --ae, --job-name, --jobs-dir, -q, probably the interface of harbor compile and harbor exec should be designed together.
also harbor compile ... --run != harbor exec ... because compile does not carry job related flags so that it's not runnable (just call back to Ryan's question last Friday)
- the current interface, i hope it could be more consistent with
harbor run, especially some shorthands like -i, -p, -o; inharbor run, -p is --path (local task/dataset directory), inharbor exec, it makes sense to use it the same way (not a-i)
under --scan, harbor exec -p cases/ produces one task per immediate subdirectory, which is almost exactly what harbor run -p dataset-dir/ does (one trial per task subdirectory). So the two commands would share a coherent rule.
This might be critical especially for users who are familiar with the harbor run commands, or even for AI agents, so that we are not confusing AI agents as well.
In terms of -i, it's a bit tricky, it means --include-task-name in harbor run, I hope -i could be the --instruction in the harbor exec. for the -i in harbor run, we can either 1. leave it be or 2. remove the shorthand; but i think either one is fine because the -i in harbor run is not widely used, and it will not be widely used as harbor exec in the future.
--collectrename to--artifact,--no-verify renamedto--disable-verification? it seems the functionalities are the same for those two. no need to introduce new cli flags. i really want to keep things conssitent- i feel there's definitely a better/expressive name for it
--scan - add
.yamlexamples forharbor exec - "reduce" related, Is it possible that we reduce more than one time?
- retries, timeouts, resource overrides, mounts, skills, MCP, logs, upload/share, plugins are absent in
harbor exec, they maybe less frequently being used, but do we need to add them? - less important but seems liek
--n-concurrent-agentsis also absent, I really want to do a full parity comparison between harbor run and exec before merging.
I think we don't want perfect configurable parity with
|


Summary
Testing