Skip to content

Refine harbor exec file inference and help text#2164

Merged
kobe0938 merged 5 commits into
mainfrom
codex/refine-harbor-exec-cleanup
Jul 2, 2026
Merged

Refine harbor exec file inference and help text#2164
kobe0938 merged 5 commits into
mainfrom
codex/refine-harbor-exec-cleanup

Conversation

@alexgshaw

@alexgshaw alexgshaw commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Tighten harbor exec file-path inference to reduce false positives while still capturing common path and dotfile patterns.
  • Clarify exec help text around experimental status and verification controls.
  • Remove the deprecated --rp reduce prompt shorthand and clean up the example exec config.
  • Add unit coverage for path inference, help text, and alias behavior.

Testing

  • Added unit tests for the new file-mention regex and prompt inference behavior.
  • Added CLI help and alias regression tests.
  • Not run (not requested).

Open in Devin Review

@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
harbor-docs Ready Ready Preview, Comment Jul 2, 2026 8:47pm

Request Review

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Enjoy a better diff viewing experience by clicking one of these URLs:

devin-ai-integration[bot]

This comment was marked as resolved.

@kobe0938 kobe0938 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and devin is right

Comment thread src/harbor/cli/exec.py Outdated
Comment thread examples/exec/map-reduce.yaml
Comment thread src/harbor/cli/exec.py

@kobe0938 kobe0938 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also add /exec/ in gitignore?

@kobe0938 kobe0938 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. is it a good idea to remove the /app prefix in those example yaml files map.yaml & map-reduce.yaml just to simplify the experience?
    "Read app/topic.md and write a concise answer to app/answer.md." ->
    "Read topic.md and write a concise answer to answer.md."

  2. also, is it good to put the CLI equivalent to map.yaml & map-reduce.yaml as comments to make it clearer for potential users.
    like
    # uv run harbor exec -p examples/exec/inputs/topic.md -i "Read topic.md and write a concise answer to answer.md." -o exec -e modal -a claude-code -m anthropic/claude-sonnet-4-5

@kobe0938

kobe0938 commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

follow-up pr of #2150

@kobe0938 kobe0938 merged commit a9653c3 into main Jul 2, 2026
5 of 8 checks passed
@kobe0938 kobe0938 deleted the codex/refine-harbor-exec-cleanup branch July 2, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants