Skip to content

Add recaptcha related errors - #10048

Merged
renkelvin merged 4 commits into
recaptchafrom
errors
Aug 1, 2022
Merged

renkelvin merged 4 commits into
recaptchafrom
errors

Conversation

@renkelvin

@renkelvin renkelvin commented Jul 27, 2022 •

Copy link
Copy Markdown
Contributor

This PR updates the 4 email auth apis (sign in, sign up, password reset, email link sign in) to support recaptcha enterprise. go/gcip-recaptcha-client-sdk-api

Development progress

@google-oss-bot

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@renkelvin
renkelvin requested a review from paulb777 July 28, 2022 00:14
@renkelvin
renkelvin marked this pull request as ready for review July 28, 2022 00:14
@renkelvin
renkelvin requested a review from rosalyntan July 28, 2022 00:15

@paulb777 paulb777 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to see a better error handling architecture, but that's out of scope for this project.

@renkelvin

Copy link
Copy Markdown
Contributor Author

I'd love to see a better error handling architecture, but that's out of scope for this project.

Yeah, agreed.

@renkelvin
renkelvin merged commit c35e4d8 into recaptcha Aug 1, 2022
@renkelvin
renkelvin deleted the errors branch August 1, 2022 16:21
@renkelvin renkelvin mentioned this pull request Aug 3, 2022
@firebase firebase locked and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants