Skip to content

Backend apis - #10063

Merged
renkelvin merged 7 commits into
recaptchafrom
backend-apis
Aug 8, 2022
Merged

Backend apis#10063
renkelvin merged 7 commits into
recaptchafrom
backend-apis

Conversation

@renkelvin

@renkelvin renkelvin commented Aug 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR updates the 4 email auth apis (sign in, sign up, password reset, email link sign in) to support recaptcha enterprise. go/gcip-recaptcha-client-sdk-api

Development progress

@renkelvin
renkelvin changed the base branch from master to recaptcha August 2, 2022 23:22
@google-oss-bot

google-oss-bot commented Aug 2, 2022

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot

google-oss-bot commented Aug 2, 2022

Copy link
Copy Markdown
Collaborator

Size Report 1

Affected Products

  • FirebaseAuth

    TypeBase (26075af)Merge (24c35fd)Diff
    CocoaPods1.20 MB-51.5 kB-1.25 MB (-104.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6VyjJVerB3.html

@renkelvin
renkelvin marked this pull request as ready for review August 3, 2022 06:41
@renkelvin
renkelvin requested a review from paulb777 August 3, 2022 06:41
paulb777
paulb777 approved these changes Aug 3, 2022
View reviewed changes

@paulb777 paulb777 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, it would also be good to have a product team reviewer as well on this series of PRs.

@renkelvin

renkelvin commented Aug 3, 2022

Copy link
Copy Markdown
Contributor Author

If possible, it would also be good to have a product team reviewer as well on this series of PRs.

Yeah, good idea.

prameshj
prameshj reviewed Aug 3, 2022
View reviewed changes

@prameshj prameshj left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for some minor nits. Thanks!

Comment thread FirebaseAuth/Sources/Backend/RPC/FIRGetOOBConfirmationCodeRequest.m
Comment thread FirebaseAuth/Sources/Backend/RPC/FIRSignUpNewUserRequest.m
Comment thread FirebaseAuth/Sources/Backend/RPC/FIRGetOOBConfirmationCodeRequest.m
Comment thread FirebaseAuth/Tests/Unit/FIRGetOOBConfirmationCodeRequestTests.m Outdated
Comment thread FirebaseAuth/Sources/Backend/RPC/FIRVerifyPasswordRequest.h
@prameshj

prameshj commented Aug 8, 2022

Copy link
Copy Markdown

/lgtm

@renkelvin
renkelvin merged commit 89f2f47 into recaptcha Aug 8, 2022
@renkelvin
renkelvin deleted the backend-apis branch August 8, 2022 17:25
@firebase firebase locked and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes
@rosalyntan rosalyntan Awaiting requested review from rosalyntan
+1 more reviewer
@prameshj prameshj prameshj left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: auth

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@renkelvin @google-oss-bot @prameshj @paulb777