Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
Greptile OverviewGreptile SummaryAdded a new DELETE endpoint for removing custom connector templates with automatic fallback to Fides-provided templates. The endpoint validates that a custom template exists and has a default fallback before deletion, then updates all existing connection configs to use the Fides-provided template. Key changes:
Issues found:
Confidence Score: 4/5
Important Files Changed
|
tests/ops/api/v1/endpoints/test_connector_template_endpoints.py
Outdated
Show resolved
Hide resolved
18 tasks
galvana
approved these changes
Feb 6, 2026
Contributor
galvana
left a comment
There was a problem hiding this comment.
This one looks good, just make the changes in the base branch and we should be good to go
27ac41c to
7f6443b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket Ticket ENG-565
Description Of Changes
Added endpoint for deleting custom templates if they have a fides provided template to fall back to.
Added fallback logic.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works