Skip to content

No versioning for custom template updates + add custom template flag#7319

Merged
Linker44 merged 9 commits intomainfrom
ENG-565-remove-replaceable-flag
Feb 6, 2026
Merged

No versioning for custom template updates + add custom template flag#7319
Linker44 merged 9 commits intomainfrom
ENG-565-remove-replaceable-flag

Conversation

@Linker44
Copy link
Copy Markdown
Contributor

@Linker44 Linker44 commented Feb 5, 2026

Ticket Ticket ENG-565

Description Of Changes

We no longer rely on versioning to update custom template connections.
Custom templates will only be replaced if the customer prompts deletion through #7320
Added flags to validate when a template is custom and if it has a fallback template available for deletion.

Code Changes

  • Removed replaceable flag.
  • Removed reliance on versioning for connection updates.
  • Added custom and file_template_available attributes to templates.

Steps to Confirm

  1. Upload a custom template for an existing integration (ex: stripe).
  2. use the connection types endpoint to list all available templates.
  3. verify the uploaded template has custom=true and file_template_available=true.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@Linker44 Linker44 self-assigned this Feb 5, 2026
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 6, 2026 7:28pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 6, 2026 7:28pm

Request Review

@Linker44 Linker44 changed the title Dont depend on versioning for updates + add custom template flag No versioning for updates + add custom template flag Feb 5, 2026
@Linker44 Linker44 marked this pull request as ready for review February 5, 2026 19:35
@Linker44 Linker44 requested a review from a team as a code owner February 5, 2026 19:35
@Linker44 Linker44 requested review from galvana and removed request for a team February 5, 2026 19:35
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 5, 2026

Greptile Overview

Greptile Summary

Removes version-based automatic replacement of custom connector templates with file-based templates. Instead of relying on versioning to determine when to replace custom templates, the PR adds two new flags:

  • custom: Indicates whether the template is custom-uploaded
  • default_connector_available: Indicates whether a Fides-provided default template exists

Key changes:

  • Removed replaceable column from custom_connector_template table and all related logic
  • Removed automatic version comparison and template replacement in CustomConnectorTemplateLoader._load_connector_templates()
  • Added delete_template() method to enable explicit deletion via PR Custom template deletion endpoint #7320
  • Updated version syncing to always match file template versions when available (not just for replaceable templates)
  • Updated all tests to verify new behavior and remove old replacement tests

Issues found:

  • Migration downgrade missing server_default for NOT NULL column - will fail on existing data
  • Unused ConnectionConfig import in connector_registry_service.py

Confidence Score: 4/5

  • Safe to merge after fixing the migration downgrade issue
  • The PR correctly removes version-based replacement logic and adds custom template flags. The changes are well-tested with comprehensive test updates. However, the migration downgrade could fail on existing data without a server_default value.
  • The migration file needs server_default added to the downgrade function

Important Files Changed

Filename Overview
src/fides/api/alembic/migrations/versions/xx_2026_02_05_1741_55ea9941018b_.py Removes replaceable column from custom_connector_template table. Downgrade adds column back without default value, which could fail on existing data.
src/fides/api/schemas/saas/connector_template.py Adds custom and default_connector_available fields to templates and list response.
src/fides/api/service/connectors/saas/connector_registry_service.py Removes version-based replacement logic. Adds delete_template method and flags for custom templates. Unused ConnectionConfig import added.

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

galvana
galvana previously requested changes Feb 6, 2026
@Linker44 Linker44 added the db-migration This indicates that a change includes a database migration label Feb 6, 2026
@Linker44 Linker44 requested a review from galvana February 6, 2026 15:15
@Linker44 Linker44 dismissed galvana’s stale review February 6, 2026 15:16

changes implemented

@Linker44 Linker44 added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit dac4f59 Feb 6, 2026
55 checks passed
@Linker44 Linker44 deleted the ENG-565-remove-replaceable-flag branch February 6, 2026 21:40
@Linker44 Linker44 changed the title No versioning for updates + add custom template flag No versioning for custom template updates + add custom template flag Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

db-migration This indicates that a change includes a database migration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants