No versioning for custom template updates + add custom template flag#7319
Merged
No versioning for custom template updates + add custom template flag#7319
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
Greptile OverviewGreptile SummaryRemoves version-based automatic replacement of custom connector templates with file-based templates. Instead of relying on versioning to determine when to replace custom templates, the PR adds two new flags:
Key changes:
Issues found:
Confidence Score: 4/5
Important Files Changed
|
src/fides/api/alembic/migrations/versions/xx_2026_02_05_1741_55ea9941018b_.py
Outdated
Show resolved
Hide resolved
added 2 commits
February 5, 2026 20:15
galvana
previously requested changes
Feb 6, 2026
src/fides/api/alembic/migrations/versions/xx_2026_02_05_1741_55ea9941018b_.py
Outdated
Show resolved
Hide resolved
...pi/alembic/migrations/versions/xx_2026_02_05_1741_55ea9941018b_removing_replaceable_field.py
Show resolved
Hide resolved
galvana
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket Ticket ENG-565
Description Of Changes
We no longer rely on versioning to update custom template connections.
Custom templates will only be replaced if the customer prompts deletion through #7320
Added flags to validate when a template is custom and if it has a fallback template available for deletion.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works