Skip to content

Conversation

@thaJeztah
Copy link
Member

This function was used internally, but is no longer used. Users should check
the value of the DOCKER_CONTENT_TRUST environment variable instead.

There are no known external users of this method, so already removing it
from the Cli interface; this method will be removed in the next release.

- Human readable description for the release notes

Go SDK: cli/command: deprecate `DockerCli.ContentTrustEnabled`. This method is no longer used and will be removed in the next release.

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 29.0.0 milestone Sep 25, 2025
@thaJeztah thaJeztah added impact/deprecation status/2-code-review area/trust kind/refactor PR's that refactor, or clean-up code area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK process/cherry-pick/28.x labels Sep 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cli/trust/trust.go 0.00% 8 Missing ⚠️
cli/command/plugin/push.go 0.00% 1 Missing ⚠️
cli/command/service/trust.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

This is a follow-up to 7609dde and
3f5b1bd, which removed support for
DCT for build and plugin commands.

As these flags are just stubs, hidden by default and no longer functional,
they don't have to reflect the current state of DCT.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the deprecate_ContentTrustEnabled branch from 025fcd8 to ec1edef Compare September 25, 2025 10:43
This function was used internally, but is no longer used. Users should check
the value of the `DOCKER_CONTENT_TRUST` environment variable instead.

There are no known external users of this method, so already removing it
from the Cli interface; this method will be removed in the next release.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@vvoland vvoland merged commit ef3c19a into docker:master Sep 25, 2025
102 of 104 checks passed
@thaJeztah thaJeztah deleted the deprecate_ContentTrustEnabled branch September 25, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/go-sdk Changes affecting the Go SDK area/trust impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code process/cherry-picked status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants