Skip to content

Conversation

@thaJeztah
Copy link
Member


This function was used internally, but is no longer used. Users should check
the value of the DOCKER_CONTENT_TRUST environment variable instead.

There are no known external users of this method, so already removing it
from the Cli interface; this method will be removed in the next release.

- Human readable description for the release notes

Go SDK: cli/command: deprecate `DockerCli.ContentTrustEnabled`. This method is no longer used and will be removed in the next release.

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 28.5.0 milestone Sep 25, 2025
@thaJeztah thaJeztah added impact/changelog impact/deprecation status/2-code-review area/trust kind/refactor PR's that refactor, or clean-up code area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK labels Sep 25, 2025
@thaJeztah
Copy link
Member Author

Second commit was added to adjust for the 28.x branch, which didn't remove support for DCT for plugins and build yet.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 47.36842% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cli/trust/trust.go 0.00% 8 Missing ⚠️
cli/command/plugin/push.go 0.00% 1 Missing ⚠️
cli/command/service/trust.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 1bae6aa)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the 28.x_backport_deprecate_ContentTrustEnabled branch from 9bdb249 to 897831c Compare September 25, 2025 10:51
These were already replaced for stubs in master.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
This function was used internally, but is no longer used. Users should check
the value of the `DOCKER_CONTENT_TRUST` environment variable instead.

There are no known external users of this method, so already removing it
from the Cli interface; this method will be removed in the next release.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 11d4048)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the 28.x_backport_deprecate_ContentTrustEnabled branch from 897831c to 118548d Compare September 25, 2025 10:55
@vvoland vvoland merged commit 2ef1b4e into docker:28.x Sep 25, 2025
92 of 93 checks passed
@thaJeztah thaJeztah deleted the 28.x_backport_deprecate_ContentTrustEnabled branch September 25, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/go-sdk Changes affecting the Go SDK area/trust impact/changelog impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants