Skip to content

Unexport config command #6286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thaJeztah merged 1 commit into from
Aug 19, 2025
Merged

Unexport config command #6286

thaJeztah merged 1 commit into from
Aug 19, 2025

Conversation

@Benehiko
Copy link
Member

@Benehiko Benehiko commented Aug 18, 2025 •
edited
Loading

This patch unexports the config command.

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

Go SDK: cli/command/config: deprecate `NewConfigCommand`. This function will be removed in the next release.

- A picture of a cute animal (not mandatory but encouraged)

@Benehiko Benehiko changed the title Commands/config Unexport config command Aug 18, 2025
@Benehiko Benehiko requested a review from thaJeztah August 18, 2025 11:07
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cli/command/config/cmd.go 0.00% 8 Missing ⚠️
cli/command/commands/commands.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Benehiko Benehiko force-pushed the commands/config branch 2 times, most recently from 6c1dd75 to 729d087 Compare August 18, 2025 15:39
@Benehiko Benehiko added impact/changelog impact/deprecation area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code labels Aug 18, 2025
@Benehiko Benehiko added this to the 29.0.0 milestone Aug 18, 2025
thaJeztah
thaJeztah reviewed Aug 18, 2025
View reviewed changes
@Benehiko
Unexport config command
cce29da 
This patch unexports the `config` command.

Signed-off-by: Alano Terblanche <[email protected]>
@Benehiko Benehiko requested a review from thaJeztah August 19, 2025 06:49
thaJeztah
thaJeztah approved these changes Aug 19, 2025
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 4c3fa4a into docker:master Aug 19, 2025
108 of 109 checks passed
@thaJeztah thaJeztah mentioned this pull request Aug 19, 2025
Merged
1 task
@thaJeztah thaJeztah mentioned this pull request Aug 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees

No one assigned

Labels

area/go-sdk Changes affecting the Go SDK impact/changelog impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code process/cherry-picked

Projects

None yet

Milestone

29.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Benehiko @codecov-commenter @thaJeztah