[28.x backport] un-export and deprecate cobra commands #6312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This patch unexports the `builder` and `bake` stub command and it adds deprecation notices on the exported functions. It also registers the commands using the new `cli/internal/commands` package when the init function executes. Signed-off-by: Alano Terblanche <[email protected]> (cherry picked from commit 1b9d076) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This patch unexports the `checkpoint` command. Signed-off-by: Alano Terblanche <[email protected]> (cherry picked from commit 3265cea) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This patch unexports the `config` command. Signed-off-by: Alano Terblanche <[email protected]> (cherry picked from commit cce29da) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This patch deprecates exported container commands and moves the implementation details to an unexported function. Commands that are affected include: - container.NewRunCommand - container.NewExecCommand - container.NewPsCommand - container.NewContainerCommand - container.NewAttachCommand - container.NewCommitCommand - container.NewCopyCommand - container.NewCreateCommand - container.NewDiffCommand - container.NewExportCommand - container.NewKillCommand - container.NewLogsCommand - container.NewPauseCommand - container.NewPortCommand - container.NewRenameCommand - container.NewRestartCommand - container.NewRmCommand - container.NewStartCommand - container.NewStatsCommand - container.NewStopCommand - container.NewTopCommand - container.NewUnpauseCommand - container.NewUpdateCommand - container.NewWaitCommand - container.NewPruneCommand Signed-off-by: Alano Terblanche <[email protected]> (cherry picked from commit 38595fe) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This patch deprecates exported image commands and moves the implementation details to an unexported function. Commands that are affected include: - image.NewBuildCommand - image.NewPullCommand - image.NewPushCommand - image.NewImagesCommand - image.NewImageCommand - image.NewHistoryCommand - image.NewImportCommand - image.NewLoadCommand - image.NewRemoveCommand - image.NewSaveCommand - image.NewTagCommand - image.NewPruneCommand Signed-off-by: Alano Terblanche <[email protected]> (cherry picked from commit e66a145) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This patch deprecates exported system commands and moves the implementation details to an unexported function. Commands that are affected include: - system.NewVersionCommand - system.NewInfoCommand - system.NewSystemCommand - system.NewEventsCommand - system.NewInspectCommand Signed-off-by: Alano Terblanche <[email protected]> (cherry picked from commit cfb8cb9) Signed-off-by: Sebastiaan van Stijn <[email protected]>
b3a9764 to
def5bfc
Compare
This patch deprecates exported network commands and moves the implementation details to an unexported function. Commands that are affected include: - network.NewNetworkCommand - network.NewPruneCommand Signed-off-by: Alano Terblanche <[email protected]> (cherry picked from commit 78a8856) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This patch deprecates exported node commands and moves the implementation details to an unexported function. Commands that are affected include: - node.NewNodeCommand Signed-off-by: Alano Terblanche <[email protected]> (cherry picked from commit ab3fcf9) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This patch deprecates exported manifest commands and moves the implementation details to an unexported function. Commands that are affected include: - manifest.NewManifestCommand Signed-off-by: Alano Terblanche <[email protected]> (cherry picked from commit 02fda07) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This patch deprecates exported secret commands and moves the implementation details to an unexported function. Commands that are affected include: - secrets.NewSecretCommand Signed-off-by: Alano Terblanche <[email protected]> (cherry picked from commit e00762e) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This patch deprecates exported service commands and moves the implementation details to an unexported function. Commands that are affected include: - service.NewServiceCommand Signed-off-by: Alano Terblanche <[email protected]> (cherry picked from commit 88178ed) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This patch deprecates exported volume commands and moves the implementation details to an unexported function. Commands that are affected include: - volume.NewVolumeCommand - volume.NewPruneCommand Signed-off-by: Alano Terblanche <[email protected]> (cherry picked from commit 9961e39) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This patch deprecates exported context commands and moves the implementation details to an unexported function. Commands that are affected include: - context.NewContextCommand Signed-off-by: Alano Terblanche <[email protected]> (cherry picked from commit 3b0edc7) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This patch deprecates exported stack commands and moves the implementation details to an unexported function. Commands that are affected include: - stack.NewStackCommand Signed-off-by: Alano Terblanche <[email protected]> (cherry picked from commit 630fe43) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This patch deprecates exported registry commands and moves the implementation details to an unexported function. Commands that are affected include: - registry.NewLoginCommand - registry.NewLogoutCommand - registry.NewSearchCommand Signed-off-by: Alano Terblanche <[email protected]> (cherry picked from commit d4588c7) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This patch deprecates exported swarm commands and moves the implementation details to an unexported function. Commands that are affected include: - swarm.NewSwarmCommand Signed-off-by: Alano Terblanche <[email protected]> (cherry picked from commit bf39340) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This patch deprecates exported plugin commands and moves the implementation details to an unexported function. Commands that are affected include: - plugin.NewPluginCommand Signed-off-by: Alano Terblanche <[email protected]> (cherry picked from commit c6b7268) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This patch deprecates exported trust commands and moves the implementation details to an unexported function. Commands that are affected include: - trust.NewTrustCommand Signed-off-by: Alano Terblanche <[email protected]> (cherry picked from commit bd8e3e4) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Benehiko
approved these changes
Aug 20, 2025
vvoland
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddTrustSigningFlags,AddTrustVerificationFlags,AddPlatformFlagutilities #6311backports:
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)