Skip to content

feat: add create sign request function with different required parameters #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwwoda merged 8 commits into from
Jul 10, 2024
Merged

feat: add create sign request function with different required parameters #878

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
798bd18
feat: add new create sign request function with different required pa…
mwwoda Jul 10, 2024
5d30a7f
lint fix
mwwoda Jul 10, 2024
cdaa662
disable too many branches warning
mwwoda Jul 10, 2024
abe4cd9
move pylint disable before the func
mwwoda Jul 10, 2024
5a1db50
fix return type
mwwoda Jul 10, 2024
9fb2ff7
fix md file
mwwoda Jul 10, 2024
bddea83
use kwargs instead
mwwoda Jul 10, 2024
85c7ce0
fix return type
mwwoda Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint fix
  • Loading branch information
@mwwoda
mwwoda committed Jul 10, 2024
commit 5d30a7f161ff3da1720c1ea6cd16240ef3a52203
2 changes: 2 additions & 0 deletions test/unit/client/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1858,6 +1858,7 @@ def test_create_sign_request(mock_client, mock_box_session, mock_sign_request_re
assert new_sign_request['declined_redirect_url'] == declined_redirect_url
assert new_sign_request['template_id'] == template_id


def test_create_sign_request_v2(mock_client, mock_box_session, mock_sign_request_response):
expected_url = f'{API.BASE_API_URL}/sign_requests'
redirect_url = 'https://www.box.com/accepted'
Expand Down Expand Up @@ -1892,6 +1893,7 @@ def test_create_sign_request_v2(mock_client, mock_box_session, mock_sign_request
assert new_sign_request['declined_redirect_url'] == declined_redirect_url
assert new_sign_request['template_id'] == template_id


def test_file_request(mock_client):
# pylint:disable=redefined-outer-name
file_request_id = '12345'
Expand Down