Skip to content

feat: add create sign request function with different required parameters - #878

Merged
mwwoda merged 8 commits into
mainfrom
expose-create-sign-request-with-different-params
Jul 10, 2024
Merged

mwwoda merged 8 commits into
mainfrom
expose-create-sign-request-with-different-params

Conversation

@mwwoda

@mwwoda mwwoda commented Jul 10, 2024

Copy link
Copy Markdown
Contributor

Some of the params (parent_folder_id and files) are no longer required since box/box-openapi@797a90d

@mwwoda mwwoda changed the title feat: add create sign request function with different required params feat: add create sign request function with different required parameters Jul 10, 2024
@coveralls

coveralls commented Jul 10, 2024 •

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 9876799947

Details

  • 29 of 37 (78.38%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 93.584%

Changes Missing Coverage Covered Lines Changed/Added Lines %
boxsdk/client/client.py 29 37 78.38%
Totals Coverage Status
Change from base Build 9837232680: 0.02%
Covered Lines: 3515
Relevant Lines: 3756

💛 - Coveralls

Comment thread boxsdk/client/client.py Outdated
Comment thread docs/usage/sign_requests.md Outdated
Comment thread docs/usage/sign_requests.md Outdated

@lukaszsocha2 lukaszsocha2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge if build is green

@mwwoda
mwwoda merged commit d972f54 into main Jul 10, 2024
@mwwoda
mwwoda deleted the expose-create-sign-request-with-different-params branch July 10, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants