fix(ui): designer-audit round 1 — sidebar overlap, count mismatch, tab split, empty-state placement, vaporware chrome - #571
Merged
Conversation
…b split, empty-state placement, vaporware chrome Fixes the P0 batch plus two P1 subtractions from the 2026-07-06 designer audit (15-surface screenshot review): - P0-1 sidebar 会话 label overlapped the 按状态/按项目 toggle on EVERY page: .maka-session-panel declared 4 grid rows for 5 children, so the 1fr track collapsed to 0 and the toggle overflowed onto the list's group label. The toggle's own chrome also referenced tokens that never existed (--surface-secondary/-primary/-tertiary, --foreground-primary, --shadow-sm) and rendered invisible. Fixed with a 5-row template and by replacing the hand-rolled buttons with the shared SettingsSegmented primitive (same family as the daily-review range tabs). - P0-2 sidebar badge said 定时任务 3 while the page tab said 4: the tab badge now counts non-completed reminders like the sidebar does, and the list's default filter is a new 进行中 view (全部/已完成 still selectable) so the number always matches the visible cards. - P0-3 skills 内置 and 已安装 tabs rendered the SAME list — now split by sourceType (bundled vs user-added), with counts on every tab. - P0-4 the shared EmptyState floated at 46% of the page and overlapped banners/cards on module pages: the absolute centering was a sidebar- only recipe living on the base .maka-empty-state class — now scoped to .maka-session-list. Daily review additionally collapses the 无活动 empty card to a one-line note when saved reports already fill the page. - P1-5 skills page now lands on skills the user can run (已安装 → 内置 → market fallback) instead of the all-即将上线 marketplace; removed the 保持系统唤醒·即将支持 tag from the automations banner. - P1-9 removed the dead 全部/排序：热门 pills that were styled like buttons but never wired. Verified per page with CDP screenshots (segmented renders, counts match, built-ins listed, no floating empty card). check-dead-css clean; @maka/ui 45/45; @maka/desktop 2109/2110 — the 1 failure (history compact artifact lifecycle) fails identically on origin/main (pre-existing, flagged separately).
jackwener
force-pushed
the
fix/ui-audit-p0-batch
branch
from
July 6, 2026 12:45
bd84f82 to
da8d653
Compare
Astro-Han
added a commit
to sunheyi6/maka-agent
that referenced
this pull request
Jul 6, 2026
apache#571 rerouted the view-mode toggle through the shared SettingsSegmented primitive; its <button> puts the label inline (no wrapping <span>) and marks selection via aria-pressed + data-pressed. Drop the <span>/type-order assumptions from the assertion.
Astro-Han
pushed a commit
that referenced
this pull request
Jul 6, 2026
#557) Adds a status/project view-mode toggle and renders project-grouped sessions as collapsible folder sections with a 4-session preview. Project headers + show-more route through UiButton; collapsed sidebar keeps a 4-row grid; session rows align left under folders. Rebases onto main incl. #571 (SettingsSegmented) and #572.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
对 15 个界面做了设计师视角的截图审查，本 PR 修复其中 P0 全部 + 两个高价值 P1 减法。
修复内容
--surface-secondary一族）导致底色透明SettingsSegmentedprimitive（与每日回顾的今日/本周/本月同族）filteredSkillssourceType真分流，每个 tab 带计数.maka-empty-state上，所有共享 EmptyState 都被波及.maka-session-list作用域；每日回顾在已有报告时空态降级为一行提示验证
后续
审查清单其余项（dark 模式层级、每日回顾重排、外观页 IA、文案人话化等）在后续轮次继续。