[codex] Improve project-grouped sidebar - #557
Merged
Merged
Conversation
sunheyi6
marked this pull request as ready for review
July 5, 2026 23:59
… project headers - Collapsed panel keeps a 4-row grid: the view-mode toggle is display:none in collapsed mode and does not participate in grid layout, so the 5-row template dropped the footer into the minmax(0,1fr) track. - Project group headers and the show-more control now route through UiButton (variant=quiet, size=nav) for the shared hover/focus/active contract, matching the status-group header; bespoke :hover/:focus-visible/svg-size CSS removed. - Set justify-content: flex-start on both: UiButton's buttonVariants base adds justify-center, which centered heading content under width:100%. - Tests: collapsed 4-row grid contract; folder-header disclosure assertion is now attribute-order independent (BaseButton reorders props).
The 32px (--space-8) indent under each project folder was redundant — folder hierarchy is already conveyed by the heading folder icon + group spacing, and it pushed session rows ~2 chars in from the project heading.
apache#571 rerouted the view-mode toggle through the shared SettingsSegmented primitive; its <button> puts the label inline (no wrapping <span>) and marks selection via aria-pressed + data-pressed. Drop the <span>/type-order assumptions from the assertion.
Contributor
|
Reviewed #557 and applied fixes on top — branch Findings & fixes:
Validation: Note: the original view-mode toggle CSS had hardcoded px + referenced non-existent tokens — #571 already replaced it with |
Astro-Han
force-pushed
the
codex/project-group-sidebar
branch
from
July 6, 2026 14:04
9fabf60 to
771fc98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The project grouping view previously did not match the requested folder-style design, and project headers were not interactive. This makes the sidebar behave like a project tree while preserving the compact session rows.
Validation
@Astro-Han please take a look.