Skip to content

Comments

fix: use correct type hint for '*path' args#300

Merged
crwilcox merged 2 commits intomasterfrom
289-fix_typing_for_path_args
Feb 4, 2021
Merged

fix: use correct type hint for '*path' args#300
crwilcox merged 2 commits intomasterfrom
289-fix_typing_for_path_args

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Feb 2, 2021

PEP 484 specifies that they be hinted as the type of a single element,
as seen from the caller's perspective.

Closes #289.

PEP 484 specifies that they be hinted as the type of a single element,
as seen from the caller's perspective.

Closes #289.
@tseaver tseaver requested review from a team, craiglabenz and dmahugh February 2, 2021 22:06
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 2, 2021
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Feb 2, 2021
@tseaver tseaver mentioned this pull request Feb 3, 2021
4 tasks
@crwilcox crwilcox merged commit 15b579f into master Feb 4, 2021
@crwilcox crwilcox deleted the 289-fix_typing_for_path_args branch February 4, 2021 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect type hints in collection()

2 participants