Skip to content

Comments

fix: type hint#271

Closed
jlsneto wants to merge 6 commits intogoogleapis:masterfrom
jlsneto:fix-firestore-type-hint
Closed

fix: type hint#271
jlsneto wants to merge 6 commits intogoogleapis:masterfrom
jlsneto:fix-firestore-type-hint

Conversation

@jlsneto
Copy link

@jlsneto jlsneto commented Dec 11, 2020

the document and collection functions can receive str or tuple of this
this goes up a false positive warning in the development

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

the document and collection functions can receive str or tuple of this
this goes up a false positive warning in the development
@jlsneto jlsneto requested a review from a team December 11, 2020 05:11
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2020
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Dec 11, 2020
Copy link
Contributor

@craiglabenz craiglabenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@craiglabenz craiglabenz added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2021
@tseaver
Copy link
Contributor

tseaver commented Feb 3, 2021

@jlsneto Thanks for the patch! Actually, the correct type hint here per PEP 484 is just str.

@tseaver
Copy link
Contributor

tseaver commented Feb 3, 2021

Superseded by #300.

@tseaver tseaver closed this Feb 3, 2021
@jlsneto jlsneto deleted the fix-firestore-type-hint branch February 7, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants