Convert theme_date() to #theme input__date

Split from form.inc twig conversion.

Re-rolled.

+++ b/core/includes/form.inc
@@ -1117,29 +1117,30 @@ function password_confirm_validate($element, &$element_state) {
-  if (empty($element['attribute']['type'])) {
-    $element['attribute']['type'] = 'date';
-  }

This issue was a typo from core.

And another typo... geez

right interdiff...

+++ b/core/includes/form.inc
@@ -1117,29 +1117,30 @@ function password_confirm_validate($element, &$element_state) {
-  if (empty($element['attribute']['type'])) {
-    $element['attribute']['type'] = 'date';
-  }
...
-  _form_set_attributes($element, array('form-' . $element['attribute']['type']));
+  _form_set_attributes($element, array('form-' . $element['#attributes']['type']));

FYI, this is a typo bug fix, that likely wouldn't have broken anything but could have since there is no 'attribute' key and it would always get set.

Fixed an issue with the patch. Sorry @rfay, got excited with my new assignment abilities.

Also, here's a markup review, note the fix.

Unassigned and likely doesn't need profiling as there is no twig template in this. Could use a review and RTBC;)

Rerolled.

Prefect re-roll, thank you @pakmanlh!

Now just need someone to do a final review/RTBC

~/htdocs/drupal8$ git apply -v 2152205-theme_date-15.patch
Checking patch core/includes/form.inc...
error: while searching for:
}

/**
 * Returns HTML for an #date form element.
 *
 * Supports HTML5 types of 'date', 'datetime', 'datetime-local', and 'time'.
 * Falls back to a plain textfield. Used as a sub-element by the datetime
 * element type.
 *
 * @param array $variables
 *   An associative array containing:
 *   - element: An associative array containing the properties of the element.
 *     Properties used: #title, #value, #options, #description, #required,
 *     #attributes, #id, #name, #type, #min, #max, #step, #value, #size.
 *
 * @ingroup themeable
 */
function theme_date($variables) {
  $element = $variables['element'];
  if (empty($element['attribute']['type'])) {
    $element['attribute']['type'] = 'date';
  }
  element_set_attributes($element, array('id', 'name', 'type', 'min', 'max', 'step', 'value', 'size'));
  _form_set_attributes($element, array('form-' . $element['attribute']['type']));

  return '<input' . new Attribute($element['#attributes']) . ' />';
}

/**

error: patch failed: core/includes/form.inc:1194
error: core/includes/form.inc: patch does not apply
Checking patch core/includes/theme.inc...
Hunk #1 succeeded at 2727 (offset -152 lines).
Checking patch core/modules/system/system.module...
Hunk #1 succeeded at 505 (offset -15 lines).

Re-rolling...

Reviewed #11, Don't need profiling because it's not a template.
Fixes a bug as demoed in screenshot in #11.
Removes a theme function.

Committed/pushed to 8.x, thanks!