Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-26773

[hbase-thirdparty] Introduce a hbase-unsafe module in hbase-thirdparty to remove the direct references of Unsafe in our main code base

    XMLWordPrintableJSON

Details

    • Reviewed
    • Introduced a new hbase-unsafe module in hbase-thirdparty.

    Description

      For java 9+, sun.misc.Unsafe is in the module jdk.unsupported. When compiling with java 11 --release 8, these symbols will not be exported and lead to compile errors.

      There is a jdk issue

      https://bugs.openjdk.java.net/browse/JDK-8214165

      But seems the jdk team does not want to fix it. So if we want to move up to java 11 but still keep the java 8 compatibility, a possible choice is to remove the direct reference of sun.misc.Unsafe so at compile time there will be no problem, and at runtime we export the jdk.unsupported so there will be no problem too.

      For more details, please see the discussion of this thread on the dev mailing list.

      https://lists.apache.org/thread/w5lrxkhswlonj09xf9hcwgvck3nsjdfx

      Attachments

        Issue Links

          blocks

          Improvement - An improvement or enhancement to an existing feature or task. HBASE-25465 Use javac --release option for supporting cross version compilation

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. HBASE-28380 [hbase-thirdparty] Build hbase-unsafe and hbase-shaded-protobuf with JDK17

          • Major - Major loss of function.
          • Open
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. PHOENIX-7037 Use or clone hbase-unsafe in Phoenix

          • Major - Major loss of function.
          • Open
          links to

          Web Link GitHub Pull Request #78

          Activity

            People

              zhangduo Duo Zhang
              zhangduo Duo Zhang
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: