Skip to content

Don't reassign cls.__new__ for Python 3.10+ #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
puddly merged 2 commits into from
Jul 20, 2023
Merged

Don't reassign cls.__new__ for Python 3.10+ #219

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fefb3a0
Don't reassign cls.__new__ for Python 3.10+
cdce8p Jul 20, 2023
1f160f3
Fix lint
cdce8p Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions zigpy_znp/types/basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import sys
import enum
import typing

Expand Down Expand Up @@ -65,10 +66,13 @@ def __init_subclass__(cls, signed=None, size=None, hex_repr=None) -> None:
cls.__str__ = super().__str__
cls.__repr__ = super().__repr__

# XXX: The enum module uses the first class with __new__ in its __dict__ as the
# member type. We have to ensure this is true for every subclass.
if "__new__" not in cls.__dict__:
cls.__new__ = cls.__new__
if sys.version_info < (3, 10):
# XXX: The enum module uses the first class with __new__ in its __dict__
# as the member type. We have to ensure this is true for
# every subclass.
# Fixed with https://github.com/python/cpython/pull/26658
if "__new__" not in cls.__dict__:
cls.__new__ = cls.__new__

def serialize(self) -> bytes:
try:
Expand Down