drivers: flash: flash_shell.c: Fix parsing of flash read
#101010
+46
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch runs clang-format on the flash_shell.c file before the real patch gets applied, otherwise the changes would be hard to read. Signed-off-by: Marcelo Roberto Jimenez <[email protected]>
This patch runs clang-format on the shell_flash_test.c file before the real patch gets applied, otherwise the changes would be hard to read. Signed-off-by: Marcelo Roberto Jimenez <[email protected]>
The parsing of the number of bytes to read in the read command was being done in hexadecimal, causing unexpected behavior. Now the number can be interpreted in decimal or hexadecimal if prefixed with 0x. Signed-off-by: Marcelo Roberto Jimenez <[email protected]>
Actually, the parameter is the number of bytes to read, not the number of double words. Signed-off-by: Marcelo Roberto Jimenez <[email protected]>
7dea44d to
33a1342
Compare
|
Contributor
|
@mrjimenez Would it be possible to log a bug for that and link it to the PR? |
Open
1 task
Contributor
Author
|
I am not sure it would be considered a bug, since the test (which has also been fixed) also expected an hexadecimal number without Fixes #101115 |
Open
1 task
de-nordic
approved these changes
Dec 18, 2025
Contributor
de-nordic
left a comment
There was a problem hiding this comment.
Looks OK.
You have won very nice looking PR number 101010.
Contributor
Author
Indeed. And in binary, it is 42! 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parsing of the number of bytes to read in the read command was being done in hexadecimal, causing unexpected behavior.
Now the number can be interpreted in decimal or hexadecimal if prefixed with 0x.
Also fixes the help test of the
flash readcommand.