fix discrepancy between 109 and 111 #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ePaul
reviewed
Jan 29, 2024
Member
|
👍 |
Co-authored-by: Paŭlo Ebermann <paul.ebermann@zalando.de>
tkrop
reviewed
Jan 29, 2024
Member
tkrop
left a comment
There was a problem hiding this comment.
@ktsypkina I think we should also improve on rule 109. At the moment it is missing a similar sentence as in 111 about that APIs must document, if they deviates from the default rejection strategy. Can you add a sentence about this after the strict recommendation too?
Member
|
👍 |
Member
|
👍 |
1 similar comment
Member
Author
|
👍 |
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change "may" to stronger "should" for additional (unknown) properties described in #111 to be compliant with requirements from server described in #109