This repository was archived by the owner on Sep 23, 2022. It is now read-only.
Replace services service with KIO #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The https://services.auth.zalando.com will be shut down. I'm extra careful with the if check.
Contributor
Author
|
👍 |
1 similar comment
Contributor
|
👍 |
NorthFury
reviewed
Aug 15, 2017
| private def callApplicationService(applicationName: String, token: String): Future[Result[Team]] = { | ||
| val url = applicationServiceUrl + applicationName | ||
| val normalizedApplicationName = | ||
| if (applicationName.startsWith("stups_")) applicationName.substring("stups_".length) else applicationName |
Member
There was a problem hiding this comment.
can be replaced with val normalizedApplicationName = applicationName.replaceFirst("^stups_", "")
|
👍 |
NorthFury
reviewed
Aug 15, 2017
| httpClient.callJson(url, Some(token)).map { | ||
| case jsObject: JsObject => | ||
| jsObject.getFields("owner").headOption match { | ||
| jsObject.getFields("team_id").headOption match { |
Member
There was a problem hiding this comment.
I think we should keep backwards compatibility.
Contributor
Author
|
👍 |
1 similar comment
Member
|
👍 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The https://services.auth.zalando.com will be shut down.
I'm extra careful with the if check.