Add insertUnique_ to PersistUniqueWrite - #1469
Merged
Merged
Conversation
- Works the same as insertUnique, but doesn't return a key
- For SQL databases this can be twice as fast since there is no SELECT
to get the key after the original INSERT
commit 093b2347762e15a12fc4422c718d6adeb3e7fb89
Author: Luke Seale <19484084+lbseale@users.noreply.github.com>
Date: Tue Jan 24 17:33:41 2023 -0800
Add a test for insertUnique_
commit 75ffc4f3eb5048d1983fab6d8b0df22e1d6f4517
Author: Luke Seale <19484084+lbseale@users.noreply.github.com>
Date: Tue Jan 24 17:33:19 2023 -0800
Add help for insertUnique_
- Also fix incorrect type annotation
commit bc81b359f454d0984062ab4f32980df75a6a85d8
Author: Luke Seale <19484084+lbseale@users.noreply.github.com>
Date: Tue Jan 24 17:31:50 2023 -0800
Add insertUnique_ to PersistUniqueWrite typeclass
- Works the same way is insertUnique, but calls insert_ instead of
insert
- Return type is Maybe (), since it insert_ doesn't return a key
Contributor
Author
|
Fixes issue #1457 |
parsonsmatt
requested changes
Mar 2, 2023
parsonsmatt
left a comment
Collaborator
There was a problem hiding this comment.
This is great, thank you! Please make a Changelog entry. I'll relesae this with 2.14.5.0
| -- | ||
| -- Linus's record was inserted to <#dataset-persist-unique-1 dataset-1>, while SPJ wasn't because SPJ already exists in <#dataset-persist-unique-1 dataset-1>. | ||
| -- | ||
| -- @since 2.14.4.4 |
Collaborator
There was a problem hiding this comment.
As an addition to a class with a default method, this is a minor version bump - let's bundle this with 2.14.5.0.
Contributor
Author
|
Thank you! Proud to have my contribution included |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
@sincedeclarations to the Haddockstylish-haskellon any changed files..editorconfigfile for details)After submitting your PR:
(unreleased)on the Changelog