Repository navigation
fix: a property template read without a receiver stops the compiler - #535
Open
mdlsvensson wants to merge 1 commit into
Open
mdlsvensson wants to merge 1 commit into
mdlsvensson wants to merge 1 commit into
Conversation
…. no longer crashes the renderer
A property with a @CSharpLua.Get or @CSharpLua.Set template got its receiver ({this}) only after a dot on another expression. Read by its bare name, through this. or base., or set in an object initializer when it has only a setter, its template was never filled in and rendering stopped with a NullReferenceException in LuaRenderer.Render, with no file or line. A bare name, this. and base. now give it the instance as its receiver (a static one its type), and an object initializer writes the setter's template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stops the compiler with a
NullReferenceExceptioninLuaRenderer.Render(LuaCodeTemplateExpressionSyntax), with no file or line.A property with a
@CSharpLua.Getor@CSharpLua.Settemplate had its template filled in only when it was read after a dot on another expression. Read by its bare name, throughthis.orbase., or set in an object initializer when it has only a setter, the template was never filled in. Now a bare name,this.andbase.give it the instance as{this}(its type for a static one), and an object initializer writes the setter's template.Tests:
PropertyTemplateWithoutReceiverTest,PropertyTemplateThroughBaseTestandSetOnlyPropertyTemplateInInitializerTestinTemplates/PropertyTemplateTests.cs. CI passes: https://github.com/wc3-dev/CSharp.lua/actions/runs/44585225960