Skip to content

fix: a property template read without a receiver stops the compiler - #535

Open
mdlsvensson wants to merge 1 commit into
yanghuan:masterfrom
wc3-dev:yh/template-property-receiver
Open

mdlsvensson wants to merge 1 commit into
yanghuan:masterfrom
wc3-dev:yh/template-property-receiver

Conversation

@mdlsvensson

Copy link
Copy Markdown
Contributor
class Clock {
  /// <summary>
  /// @CSharpLua.Get = "os.time()"
  /// </summary>
  public static extern int Now { get; }

  public static int Later() {
    return Now + 1;
  }
}

stops the compiler with a NullReferenceException in LuaRenderer.Render(LuaCodeTemplateExpressionSyntax), with no file or line.

A property with a @CSharpLua.Get or @CSharpLua.Set template had its template filled in only when it was read after a dot on another expression. Read by its bare name, through this. or base., or set in an object initializer when it has only a setter, the template was never filled in. Now a bare name, this. and base. give it the instance as {this} (its type for a static one), and an object initializer writes the setter's template.

Tests: PropertyTemplateWithoutReceiverTest, PropertyTemplateThroughBaseTest and SetOnlyPropertyTemplateInInitializerTest in Templates/PropertyTemplateTests.cs. CI passes: https://github.com/wc3-dev/CSharp.lua/actions/runs/44585225960

…. no longer crashes the renderer

A property with a @CSharpLua.Get or @CSharpLua.Set template got its receiver ({this}) only after a dot on another expression. Read by its bare name, through this. or base., or set in an object initializer when it has only a setter, its template was never filled in and rendering stopped with a NullReferenceException in LuaRenderer.Render, with no file or line. A bare name, this. and base. now give it the instance as its receiver (a static one its type), and an object initializer writes the setter's template.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant